You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Zsolt Miskolczi <zs...@gmail.com> on 2025/09/15 12:05:50 UTC
Spell checking bot report
Hi,
PR: https://github.com/apache/hive/pull/6043
I have a PR that got a mysterious spell-checking error:
The bot reports files that I haven't touched at all.
My question is, what can be the correct action taken to pass the spell
check?
I'm afraid there can be some recent change that caused the issue - I had a
green build on this PR before, and it didn't fail due to spell-checking
errors.
There are two interesting facts about the spell-checking problems:
- due to the logs, they are just warnings:
> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
> line 659, columns 70-83, Warning - `bucketedtables` is not a recognized
> word. (unrecognized-spelling)
> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
> line 659, columns 51-64, Warning - `languagemanual` is not a recognized
> word. (unrecognized-spelling)
> Warning: serde/src/java/org/apache/hadoop/hive/serde
> 2/teradata/TeradataBinarySerde.java: line 80, columns 45-63, Warning -
> `teradatabinaryserde` is not a recognized word. (unrecognized-spelling)
- The PR that causes the issue got the same error:
https://github.com/apache/hive/pull/6031
[image: image.png]
[image: image.png]
Re: Spell checking bot report
Posted by Stamatis Zampetakis <za...@gmail.com>.
Thanks everyone for the feedback. I created
https://issues.apache.org/jira/browse/HIVE-29207 for the removal and
respective PR is ready.
On Wed, Sep 17, 2025 at 10:23 AM Butao Zhang <bu...@163.com> wrote:
>
> +1 disable the spell checking bot.
> I don't really feel the practical benefits of this tool. But it often causes some compilation issues.
>
>
> Thanks,
> Butao Zhang
>
> ---- Replied Message ----
> FromLászló Bodor<bo...@gmail.com>
> Date9/17/2025 16:17
> To<de...@hive.apache.org>
> SubjectRe: Spell checking bot report
> +1 to disable
>
> Recent reports clearly show that the spell-check isn't able to adapt to tech thingy :) And I don't think we have the capacity to improve the vocabulary to an acceptable state. The only valid reported word was "calcualtion", this is quite a bad ratio.
>
> Unrecognized words (7)
> bucketedtables
> hackersdelight
> http
> languagemanual
> stackoverflow
> teradatabinaryserde
> wiki
>
> Unrecognized words (1)
> HTTP
>
> Unrecognized words (6)
> calcualtion
> Chrono
> getenv
> ntz
> OOM
> unsign
>
>
>
> On Wed, 17 Sept 2025 at 10:09, Ayush Saxena <ay...@gmail.com> wrote:
>>
>> +1 to disable this check
>>
>> -Ayush
>>
>> On Wed, 17 Sept 2025 at 13:37, Denys Kuzmenko <dk...@apache.org> wrote:
>> >
>> > +1 for disabling spell check action
Re: Spell checking bot report
Posted by Butao Zhang <bu...@163.com>.
+1 disable the spell checking bot.
I don't really feel the practical benefits of this tool. But it often causes some compilation issues.
Thanks,
Butao Zhang
---- Replied Message ----
| From | László Bodor<bo...@gmail.com> |
| Date | 9/17/2025 16:17 |
| To | <de...@hive.apache.org> |
| Subject | Re: Spell checking bot report |
+1 to disable
Recent reports clearly show that the spell-check isn't able to adapt to tech thingy :) And I don't think we have the capacity to improve the vocabulary to an acceptable state. The only valid reported word was "calcualtion", this is quite a bad ratio.
Unrecognized words (7)
bucketedtables
hackersdelight
http
languagemanual
stackoverflow
teradatabinaryserde
wiki
Unrecognized words (1)
HTTP
Unrecognized words (6)
calcualtion
Chrono
getenv
ntz
OOM
unsign
On Wed, 17 Sept 2025 at 10:09, Ayush Saxena <ay...@gmail.com> wrote:
+1 to disable this check
-Ayush
On Wed, 17 Sept 2025 at 13:37, Denys Kuzmenko <dk...@apache.org> wrote:
>
> +1 for disabling spell check action
Re: Spell checking bot report
Posted by László Bodor <bo...@gmail.com>.
+1 to disable
Recent reports clearly show that the spell-check isn't able to adapt to
tech thingy :) And I don't think we have the capacity to improve the
vocabulary to an acceptable state. The only valid reported word was
"calcualtion", this is quite a bad ratio.
Unrecognized words (7)
bucketedtables
hackersdelight
http
languagemanual
stackoverflow
teradatabinaryserde
wiki
Unrecognized words (1)
HTTP
Unrecognized words (6)
calcualtion
Chrono
getenv
ntz
OOM
unsign
On Wed, 17 Sept 2025 at 10:09, Ayush Saxena <ay...@gmail.com> wrote:
> +1 to disable this check
>
> -Ayush
>
> On Wed, 17 Sept 2025 at 13:37, Denys Kuzmenko <dk...@apache.org>
> wrote:
> >
> > +1 for disabling spell check action
>
Re: Spell checking bot report
Posted by Ayush Saxena <ay...@gmail.com>.
+1 to disable this check
-Ayush
On Wed, 17 Sept 2025 at 13:37, Denys Kuzmenko <dk...@apache.org> wrote:
>
> +1 for disabling spell check action
Re: Spell checking bot report
Posted by Denys Kuzmenko <dk...@apache.org>.
+1 for disabling spell check action
Re: Spell checking bot report
Posted by Stamatis Zampetakis <za...@gmail.com>.
Spell checking is broken again due to another commit:
https://github.com/apache/hive/commit/d90574c9c8d5f06b6fb0ba3fd94431375a97b286
Personally, I find the overhead of maintaining this action/check bigger
than its benefit. It only applies to one small module (serde) and still it
reports many false positives that need to be handled with follow-up
commits. If its usage was ever extended to all modules I feel that we would
have to push extra commits for every single PR.
I am inclined to disable and remove this spell checking action but I would
like to see what others think. Some concerns about the overall benefit were
also raised in the past [1].
Best,
Stamatis
[1] https://lists.apache.org/thread/n7k808bkxtclww95fhgkznfsol32f0mn
On Tue, Sep 16, 2025 at 9:43 AM Stamatis Zampetakis <za...@gmail.com>
wrote:
> The PR for fixing the spelling errors is ready:
> https://github.com/apache/hive/pull/6077
>
> If you want to see the build green please +1 and merge :)
>
> Best,
> Stamatis
>
> On Mon, Sep 15, 2025 at 2:56 PM Zsolt Miskolczi <zs...@gmail.com>
> wrote:
>
>> Thank you, Stamatis.
>> I didn't know that it was possible to merge a PR with that kind of error
>> at all. So I assumed it is a blocker.
>>
>> Thanks,
>> Zsolt
>>
>> Stamatis Zampetakis <za...@gmail.com> ezt írta (időpont: 2025. szept.
>> 15., H, 14:52):
>>
>>> I think that the errors are caused by a PR that I merged recently. I
>>> didn't notice that spell checks failed. I will raise a PR to address the
>>> failures. In the meantime, you can ignore the failures and merge the PR if
>>> the other checks are green.
>>>
>>> Best,
>>> Stamatis
>>>
>>> On Mon, Sep 15, 2025 at 2:08 PM Zsolt Miskolczi <
>>> zsolt.miskolczi@gmail.com> wrote:
>>>
>>>> Hi,
>>>>
>>>> PR: https://github.com/apache/hive/pull/6043
>>>>
>>>> I have a PR that got a mysterious spell-checking error:
>>>> The bot reports files that I haven't touched at all.
>>>>
>>>> My question is, what can be the correct action taken to pass the spell
>>>> check?
>>>> I'm afraid there can be some recent change that caused the issue - I
>>>> had a green build on this PR before, and it didn't fail due to
>>>> spell-checking errors.
>>>>
>>>> There are two interesting facts about the spell-checking problems:
>>>> - due to the logs, they are just warnings:
>>>>
>>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>>>> line 659, columns 70-83, Warning - `bucketedtables` is not a recognized
>>>>> word. (unrecognized-spelling)
>>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>>>> line 659, columns 51-64, Warning - `languagemanual` is not a recognized
>>>>> word. (unrecognized-spelling)
>>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde
>>>>> 2/teradata/TeradataBinarySerde.java: line 80, columns 45-63, Warning
>>>>> - `teradatabinaryserde` is not a recognized word.
>>>>> (unrecognized-spelling)
>>>>
>>>> - The PR that causes the issue got the same error:
>>>> https://github.com/apache/hive/pull/6031
>>>>
>>>>
>>>> [image: image.png]
>>>> [image: image.png]
>>>>
>>>
Re: Spell checking bot report
Posted by Stamatis Zampetakis <za...@gmail.com>.
The PR for fixing the spelling errors is ready:
https://github.com/apache/hive/pull/6077
If you want to see the build green please +1 and merge :)
Best,
Stamatis
On Mon, Sep 15, 2025 at 2:56 PM Zsolt Miskolczi <zs...@gmail.com>
wrote:
> Thank you, Stamatis.
> I didn't know that it was possible to merge a PR with that kind of error
> at all. So I assumed it is a blocker.
>
> Thanks,
> Zsolt
>
> Stamatis Zampetakis <za...@gmail.com> ezt írta (időpont: 2025. szept.
> 15., H, 14:52):
>
>> I think that the errors are caused by a PR that I merged recently. I
>> didn't notice that spell checks failed. I will raise a PR to address the
>> failures. In the meantime, you can ignore the failures and merge the PR if
>> the other checks are green.
>>
>> Best,
>> Stamatis
>>
>> On Mon, Sep 15, 2025 at 2:08 PM Zsolt Miskolczi <
>> zsolt.miskolczi@gmail.com> wrote:
>>
>>> Hi,
>>>
>>> PR: https://github.com/apache/hive/pull/6043
>>>
>>> I have a PR that got a mysterious spell-checking error:
>>> The bot reports files that I haven't touched at all.
>>>
>>> My question is, what can be the correct action taken to pass the spell
>>> check?
>>> I'm afraid there can be some recent change that caused the issue - I had
>>> a green build on this PR before, and it didn't fail due to spell-checking
>>> errors.
>>>
>>> There are two interesting facts about the spell-checking problems:
>>> - due to the logs, they are just warnings:
>>>
>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>>> line 659, columns 70-83, Warning - `bucketedtables` is not a recognized
>>>> word. (unrecognized-spelling)
>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>>> line 659, columns 51-64, Warning - `languagemanual` is not a recognized
>>>> word. (unrecognized-spelling)
>>>> Warning: serde/src/java/org/apache/hadoop/hive/serde
>>>> 2/teradata/TeradataBinarySerde.java: line 80, columns 45-63, Warning -
>>>> `teradatabinaryserde` is not a recognized word. (unrecognized-spelling)
>>>
>>> - The PR that causes the issue got the same error:
>>> https://github.com/apache/hive/pull/6031
>>>
>>>
>>> [image: image.png]
>>> [image: image.png]
>>>
>>
Re: Spell checking bot report
Posted by Zsolt Miskolczi <zs...@gmail.com>.
Thank you, Stamatis.
I didn't know that it was possible to merge a PR with that kind of error at
all. So I assumed it is a blocker.
Thanks,
Zsolt
Stamatis Zampetakis <za...@gmail.com> ezt írta (időpont: 2025. szept.
15., H, 14:52):
> I think that the errors are caused by a PR that I merged recently. I
> didn't notice that spell checks failed. I will raise a PR to address the
> failures. In the meantime, you can ignore the failures and merge the PR if
> the other checks are green.
>
> Best,
> Stamatis
>
> On Mon, Sep 15, 2025 at 2:08 PM Zsolt Miskolczi <zs...@gmail.com>
> wrote:
>
>> Hi,
>>
>> PR: https://github.com/apache/hive/pull/6043
>>
>> I have a PR that got a mysterious spell-checking error:
>> The bot reports files that I haven't touched at all.
>>
>> My question is, what can be the correct action taken to pass the spell
>> check?
>> I'm afraid there can be some recent change that caused the issue - I had
>> a green build on this PR before, and it didn't fail due to spell-checking
>> errors.
>>
>> There are two interesting facts about the spell-checking problems:
>> - due to the logs, they are just warnings:
>>
>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>> line 659, columns 70-83, Warning - `bucketedtables` is not a recognized
>>> word. (unrecognized-spelling)
>>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>>> line 659, columns 51-64, Warning - `languagemanual` is not a recognized
>>> word. (unrecognized-spelling)
>>> Warning: serde/src/java/org/apache/hadoop/hive/serde
>>> 2/teradata/TeradataBinarySerde.java: line 80, columns 45-63, Warning -
>>> `teradatabinaryserde` is not a recognized word. (unrecognized-spelling)
>>
>> - The PR that causes the issue got the same error:
>> https://github.com/apache/hive/pull/6031
>>
>>
>> [image: image.png]
>> [image: image.png]
>>
>
Re: Spell checking bot report
Posted by Stamatis Zampetakis <za...@gmail.com>.
I think that the errors are caused by a PR that I merged recently. I didn't
notice that spell checks failed. I will raise a PR to address the failures.
In the meantime, you can ignore the failures and merge the PR if the other
checks are green.
Best,
Stamatis
On Mon, Sep 15, 2025 at 2:08 PM Zsolt Miskolczi <zs...@gmail.com>
wrote:
> Hi,
>
> PR: https://github.com/apache/hive/pull/6043
>
> I have a PR that got a mysterious spell-checking error:
> The bot reports files that I haven't touched at all.
>
> My question is, what can be the correct action taken to pass the spell
> check?
> I'm afraid there can be some recent change that caused the issue - I had a
> green build on this PR before, and it didn't fail due to spell-checking
> errors.
>
> There are two interesting facts about the spell-checking problems:
> - due to the logs, they are just warnings:
>
>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>> line 659, columns 70-83, Warning - `bucketedtables` is not a recognized
>> word. (unrecognized-spelling)
>> Warning: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java:
>> line 659, columns 51-64, Warning - `languagemanual` is not a recognized
>> word. (unrecognized-spelling)
>> Warning: serde/src/java/org/apache/hadoop/hive/serde
>> 2/teradata/TeradataBinarySerde.java: line 80, columns 45-63, Warning -
>> `teradatabinaryserde` is not a recognized word. (unrecognized-spelling)
>
> - The PR that causes the issue got the same error:
> https://github.com/apache/hive/pull/6031
>
>
> [image: image.png]
> [image: image.png]
>