You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "seung-00 (via GitHub)" <gi...@apache.org> on 2026/09/10 15:57:33 UTC

[PR] [ZEPPELIN-6705] Refactor shell terminal session management [zeppelin]

seung-00 opened a new pull request, #5473:
URL: https://github.com/apache/zeppelin/pull/5473

     ### What is this PR for?
   This PR refactors `TerminalService` into `TerminalSession` to clarify its role and lifecycle.
   
   The `TerminalService` can suggest a shared, long-lived component that provides terminal operations. In practice, each instance owns a shell process and I/O resources for one terminal connection and should be created and closed with that connection. I believe this mismatch contributed to the missing process cleanup addressed in #5447. `TerminalSession` addresses this by aligning its lifecycle with the terminal process.
   
   ### What type of PR is it?
   Refactoring
   
   ### Todos
   
   
   ### What is the Jira issue?
   - https://issues.apache.org/jira/browse/ZEPPELIN/ZEPPELIN-6705
   - [ZEPPELIN-6705]
   
   ### How should this be tested?
   - Run the shell module tests: `./mvnw test -pl shell.`
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the license files need to update? N
   * Is there breaking changes for older versions? N
   * Does this needs documentation? N
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6705] Refactor shell terminal session management [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee commented on PR #5473:
URL: https://github.com/apache/zeppelin/pull/5473#issuecomment-5651759649

   Merged into master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ZEPPELIN-6705] Refactor shell terminal session management [zeppelin]

Posted by "tbonelee (via GitHub)" <gi...@apache.org>.
tbonelee merged PR #5473:
URL: https://github.com/apache/zeppelin/pull/5473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org