You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/05/08 23:22:17 UTC
Review Request 59073: Updated Docker containerizer tests to use the
old naming scheme.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59073/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This changes test expectations of Docker container names back to the
0.22 scheme and simultaneously updates the tests to the new
containerizer interface.
Diffs
-----
src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
Diff: https://reviews.apache.org/r/59073/diff/1/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 59073: Updated Docker containerizer tests to use
the old naming scheme.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59073/#review174664
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On May 11, 2017, 12:26 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59073/
> -----------------------------------------------------------
>
> (Updated May 11, 2017, 12:26 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Bugs: MESOS-7449
> https://issues.apache.org/jira/browse/MESOS-7449
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This changes test expectations of Docker container names back to the
> 0.22 scheme and simultaneously updates the tests to the new
> containerizer interface.
>
>
> Diffs
> -----
>
> src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
>
>
> Diff: https://reviews.apache.org/r/59073/diff/3/
>
>
> Testing
> -------
>
> See last patch in chain.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 59073: Updated Docker containerizer tests to use
the old naming scheme.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59073/
-----------------------------------------------------------
(Updated May 10, 2017, 5:26 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Fixed a few root tests that didn't pass the same flags to the containerizer and agent.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This changes test expectations of Docker container names back to the
0.22 scheme and simultaneously updates the tests to the new
containerizer interface.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
Diff: https://reviews.apache.org/r/59073/diff/3/
Changes: https://reviews.apache.org/r/59073/diff/2-3/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu
Re: Review Request 59073: Updated Docker containerizer tests to use
the old naming scheme.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59073/
-----------------------------------------------------------
(Updated May 10, 2017, 1:32 p.m.)
Review request for mesos and Jie Yu.
Changes
-------
Missed a line.
Bugs: MESOS-7449
https://issues.apache.org/jira/browse/MESOS-7449
Repository: mesos
Description
-------
This changes test expectations of Docker container names back to the
0.22 scheme and simultaneously updates the tests to the new
containerizer interface.
Diffs (updated)
-----
src/tests/containerizer/docker_containerizer_tests.cpp 4eef399b05f6e35d75c7c23992f0ccda04576277
Diff: https://reviews.apache.org/r/59073/diff/2/
Changes: https://reviews.apache.org/r/59073/diff/1-2/
Testing
-------
See last patch in chain.
Thanks,
Joseph Wu