You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/12/07 08:48:30 UTC
[GitHub] [nifi] turcsanyip opened a new pull request #5580: NIFI-9390: Source components can ingest FlowFiles eagerly in stateles…
turcsanyip opened a new pull request #5580:
URL: https://github.com/apache/nifi/pull/5580
…s dataflows
Some processors (like MergeContent/Record with minimum size 1) can process all available FlowFiles from their input queue
in a batch but will not wait for more FlowFiles (that would be ingested by the source component).
Source components used to be triggered once and ingest the input data one by one which is not appropriate
for the use case mentioned above.
Introduced eager ingestion of FlowFiles where the source component feeds the flow up until transaction thresholds reached
or no more input data available.
https://issues.apache.org/jira/browse/NIFI-9390
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `main`)?
- [ ] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #5580: NIFI-9390: Source components can ingest FlowFiles eagerly in stateles…
Posted by GitBox <gi...@apache.org>.
markap14 commented on pull request #5580:
URL: https://github.com/apache/nifi/pull/5580#issuecomment-1006098373
Thanks for digging into this @turcsanyip. I'm a bit concerned about the notion of adding an "eager" fetch though. It results in some significant changes to the framework, and it tends to be taking us in a direction that I don't personally believe is the right direction. It means that in order to use Merge related processors you'll need to know that and configure the engine as such. Otherwise the Merge processors will still appear to work but won't merge anything, which can flood downstream systems with millions of tiny files, etc. Plus it's a bit confusing for users because you're configuring something that is very specific to the dataflow from outside of the dataflow.
I think we can address the issue very differently, though. Simply by updating MergeContent / MergeRecord so that they only create the smallest bin if they first poll and have no data available. Otherwise, we don't 'process' a bin unless the bin is full. I have created a PR that does this. Please check that out. https://github.com/apache/nifi/pull/5634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip commented on pull request #5580: NIFI-9390: Source components can ingest FlowFiles eagerly in stateles…
Posted by GitBox <gi...@apache.org>.
turcsanyip commented on pull request #5580:
URL: https://github.com/apache/nifi/pull/5580#issuecomment-1009723597
Closed this PR in favour of #5634.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] turcsanyip closed pull request #5580: NIFI-9390: Source components can ingest FlowFiles eagerly in stateles…
Posted by GitBox <gi...@apache.org>.
turcsanyip closed pull request #5580:
URL: https://github.com/apache/nifi/pull/5580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org