You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/04/27 09:42:43 UTC

[GitHub] [iotdb] xuesyn opened a new pull request #3079: name parameters

xuesyn opened a new pull request #3079:
URL: https://github.com/apache/iotdb/pull/3079


   ## Description
   
   This PR has renamed some parameters in iotdb-cluster.properties and iotdb-engine.properties
   
   
   This PR has:
   - [ ] been self-reviewed.
       - [ ] concurrent read
       - [ ] concurrent write
       - [ ] concurrent read and write 
   - [ ] added documentation for new or modified features or behaviors.
   - [ ] added Javadocs for most classes and all non-trivial methods. 
   - [ ] added or updated version, __license__, or notice information
   - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious 
     for an unfamiliar reader.
   - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold 
     for code coverage.
   - [ ] added integration tests.
   - [ ] been tested in a test IoTDB cluster.
   
   <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items 
   apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items 
   from the checklist above are strictly necessary, but it would be very helpful if you at least 
   self-review the PR. -->
   
   <hr>
   
   ##### Key changed/added classes (or packages if there are too many classes) in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] xuesyn closed pull request #3079: rename rpc_thrift_compression_enable to rpc_compression_enable, thrift_max_frame_size to rpc_max_frame_size and thrift_init_buffer_size to rpc_init_buffer_size

Posted by GitBox <gi...@apache.org>.
xuesyn closed pull request #3079:
URL: https://github.com/apache/iotdb/pull/3079


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [iotdb] jixuan1989 commented on pull request #3079: rename rpc_thrift_compression_enable to rpc_compression_enable, thrift_max_frame_size to rpc_max_frame_size and thrift_init_buffer_size to rpc_init_buffer_size

Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on pull request #3079:
URL: https://github.com/apache/iotdb/pull/3079#issuecomment-835749898


   Will close this PR if no response.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org