[GitHub] [ozone] adoroszlai commented on a change in pull request #3024: HDDS-6162. Limit OM pending request size to avoid taking too much memory

[GitBox <gi...@apache.org>]

adoroszlai commented on a change in pull request #3024:
URL: https://github.com/apache/ozone/pull/3024#discussion_r793991692



##########
File path: hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/ratis/OzoneManagerDoubleBuffer.java
##########
@@ -103,6 +103,8 @@
 
   private final boolean isRatisEnabled;
   private final boolean isTracingEnabled;
+  private final AtomicLong availPendingRequestNum;
+  private final Object monitor;

Review comment:
       Would it be simpler and safer to use a single `Semaphore` object instead of these two variables?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org