You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/19 04:34:28 UTC
[GitHub] [skywalking-python] alonelaval opened a new pull request #40: Add ignore_suffix Config
alonelaval opened a new pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] wu-sheng commented on pull request #40: Add ignore_suffix Config
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40#issuecomment-660585924
Please create a new branch from the upstream master. The commit loga include many unrelated things
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] alonelaval commented on pull request #40: Add ignore_suffix Config
Posted by GitBox <gi...@apache.org>.
alonelaval commented on pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40#issuecomment-660586599
> Please create a new branch from the upstream master. The commit loga include many unrelated things
ok, next i will create new branch...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] alonelaval commented on pull request #40: Add ignore_suffix Config
Posted by GitBox <gi...@apache.org>.
alonelaval commented on pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40#issuecomment-660611635
> LGTM
I tested in 8.0.1 backend...running will
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 commented on a change in pull request #40: Add ignore_suffix Config
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40#discussion_r456872980
##########
File path: skywalking/trace/context/__init__.py
##########
@@ -76,6 +88,15 @@ def new_exit_span(self, op: str, peer: str, carrier: 'Carrier' = None) -> Span:
return span
+ def ignore_check(self, op: str, kind: Kind):
+ suffix_idx = op.rfind(".")
+ if suffix_idx > -1 and config.ignore_suffix.find(op[op.rfind("."):]) > -1:
Review comment:
```suggestion
if suffix_idx > -1 and config.ignore_suffix.find(op[suffix_idx:]) > -1:
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-python] kezhenxu94 merged pull request #40: Add ignore_suffix Config
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #40:
URL: https://github.com/apache/skywalking-python/pull/40
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org