You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/02 17:24:30 UTC
[GitHub] zheng-da commented on a change in pull request #10783: Fix 'make
clean USE_MKLDNN=1' will build mkldnn issue
zheng-da commented on a change in pull request #10783: Fix 'make clean USE_MKLDNN=1' will build mkldnn issue
URL: https://github.com/apache/incubator-mxnet/pull/10783#discussion_r185574502
##########
File path: Makefile
##########
@@ -66,13 +66,22 @@ $(warning "USE_MKL2017 is deprecated. We will switch to USE_MKLDNN.")
endif
ifeq ($(USE_MKLDNN), 1)
+ifeq ($(MAKECMDGOALS),)
Review comment:
so now people need to define MAKECMDGOALS manually to compile mxnet with mkldnn?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services