You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by bhuvnesh2703 <gi...@git.apache.org> on 2016/04/01 08:27:36 UTC
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
GitHub user bhuvnesh2703 opened a pull request:
https://github.com/apache/incubator-hawq/pull/546
HAWQ-617 Add option to skip syncing configuration files
Currently Activate standby operations uses 'hawq config' to update hawq-site.xml. However, in case any of the HAWQ host is down, the operation fails while syncing up the configuration. In case of big clusters, there can be few segment hosts which are down and that will prohibit activating standby.
Thus, introduced a new flag in hawq config to ignore bad hosts and continue syncing files on hosts on which test ssh is successful
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-617
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/546.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #546
----
commit 7e8331a7e314c9d5b7f2ec65078fa069271a284d
Author: Bhuvnesh Chaudhary <bc...@pivotal.io>
Date: 2016-04-01T06:14:54Z
[#116576425] - Add option to ignore hosts on which SSH test fails to skip syncing configuration files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-205625040
@bhuvnesh2703 Now 'hawq stop' works just like '--ignore-bad-hosts' always enabled. But 'hawq stop' should only check if hawq process is running on the node, it should fail if the node is not available. We will fix that in another jira.
It's ok to apply the 'option' to 'hawq stop' next time when we fixing above hawq stop check issues. But if it convenience, please also apply it to 'hawq stop' so we can keep the option works for both start and stop. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-205627238
BTW, it's better to squash the commits since there is one commit have merged things and un-format name.
See the commit 'c5c7d8fc0757822d21e18958e03d1e536fc27a56':
"Merge branch 'master' into HAWQ-617"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/546#discussion_r58481787
--- Diff: .gitignore ---
@@ -1,54 +1 @@
-# Object files
--- End diff --
I see you removed all the lines in .gitignore, I think we should not modify and change it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by bhuvnesh2703 <gi...@git.apache.org>.
Github user bhuvnesh2703 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-205138715
Thank you @radarwave for the feedback
Added the option to start all segments, but not to stop, because stop already has a check which verifies if there is an existing postgres process before attempt to stop.
Let me know if there are any comments which needs to be fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by bhuvnesh2703 <gi...@git.apache.org>.
Github user bhuvnesh2703 commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-206106913
@radarwave Thanks for the review, will fix the stop option after this pull request, may be next week. Since this is a blocker for Ambari, i will prefer merge this and continue with Ambari testing, and do the stop option thing next week. Is that okay for you ? If so, please +1 and i will then commit. I will squash the commits before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by bhuvnesh2703 <gi...@git.apache.org>.
Github user bhuvnesh2703 commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/546#discussion_r58235606
--- Diff: .gitignore ---
@@ -1,54 +1 @@
-# Object files
--- End diff --
will delete it, not needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-204319977
How about pass this option to hawq stop/start cluster?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/546#discussion_r58170586
--- Diff: .gitignore ---
@@ -1,54 +1 @@
-# Object files
--- End diff --
Why changing to .gitignore file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/546
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-617 Add option to skip syncing c...
Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the pull request:
https://github.com/apache/incubator-hawq/pull/546#issuecomment-206107586
Sure, we will track the stop opition in https://issues.apache.org/jira/browse/HAWQ-626
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---