You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Mugdha Varadkar <mu...@freestoneinfotech.com> on 2016/04/14 10:16:27 UTC
Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752
Repository: ambari
Description
-------
Add HSM support configuration properties for Ranger KMS in hdp-2.5
Diffs
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
Diff: https://reviews.apache.org/r/46016/diff/
Testing
-------
Installed Ranger KMS centos6.
Thanks,
Mugdha Varadkar
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
> On April 15, 2016, 4:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml, line 26
> > <https://reviews.apache.org/r/46016/diff/2/?file=1346211#file1346211line26>
> >
> > I don't think we ship 0.6.0.2.5; does it need to get added to common services? Maybe Jayush who has more experience with common services can comment.
For HDP-2.5, need RANGER_KMS version to be 0.6.0
- Mugdha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129141
-----------------------------------------------------------
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jayush Luniya <jl...@hortonworks.com>.
> On April 15, 2016, 4:37 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml, line 26
> > <https://reviews.apache.org/r/46016/diff/2/?file=1346211#file1346211line26>
> >
> > I don't think we ship 0.6.0.2.5; does it need to get added to common services? Maybe Jayush who has more experience with common services can comment.
>
> Mugdha Varadkar wrote:
> For HDP-2.5, need RANGER_KMS version to be 0.6.0
Yes this change should be fine.
- Jayush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129141
-----------------------------------------------------------
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129141
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py (lines 209 - 211)
<https://reviews.apache.org/r/46016/#comment192602>
Instead of the if/else conditions, you can use the default("/foo/bar", defaultValue) construct (see above in this file)
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml (line 26)
<https://reviews.apache.org/r/46016/#comment192604>
I don't think we ship 0.6.0.2.5; does it need to get added to common services? Maybe Jayush who has more experience with common services can comment.
- Jonathan Hurley
On April 15, 2016, 1:34 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 15, 2016, 1:34 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
> On April 20, 2016, 7:58 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 238
> > <https://reviews.apache.org/r/46016/diff/3/?file=1347599#file1347599line238>
> >
> > Reverse the checks to
> > if params.stack_support_kms_hsm and params.enable_kms_hsm:
Address in latest patch
- Mugdha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129704
-----------------------------------------------------------
On April 20, 2016, 11:14 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 11:14 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 658c56f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py cf56acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py f63d660
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 4bdbd80
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 4cead39
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129704
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 238)
<https://reviews.apache.org/r/46016/#comment193244>
Reverse the checks to
if params.stack_support_kms_hsm and params.enable_kms_hsm:
- Jayush Luniya
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129887
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 20, 2016, 7:14 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 7:14 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 658c56f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py cf56acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py f63d660
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 4bdbd80
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 4cead39
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
-----------------------------------------------------------
(Updated April 20, 2016, 11:14 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
Changes
-------
Address Jayush Luniya comments to use default construct and reverse checks
Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752
Repository: ambari
Description
-------
Add HSM support configuration properties for Ranger KMS in hdp-2.5
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 658c56f
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py cf56acf
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py f63d660
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 4bdbd80
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 4cead39
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
Diff: https://reviews.apache.org/r/46016/diff/
Testing
-------
Installed Ranger KMS centos6.
Thanks,
Mugdha Varadkar
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
> On April 18, 2016, 5:13 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py, line 238
> > <https://reviews.apache.org/r/46016/diff/3/?file=1347599#file1347599line238>
> >
> > If a feature can be service config property driven do we really need to add a stack-feature? Would "if params.enable_kms_hsm" check be sufficient?
It can be sufficient as I have handled it as enable_kms_hsm = default("/configurations/dbks-site/ranger.ks.hsm.enabled", False).
I added a extra flag just to simplify implementation and ranger.ks.hsm.enabled will only be available under stack-2.5 (Also Ranger KMS HSM is a new feature in stack-2.5)
- Mugdha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129290
-----------------------------------------------------------
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129290
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py (line 238)
<https://reviews.apache.org/r/46016/#comment192765>
If a feature can be service config property driven do we really need to add a stack-feature? Would "if params.enable_kms_hsm" check be sufficient?
- Jayush Luniya
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
> On April 20, 2016, 7:56 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py, line 210
> > <https://reviews.apache.org/r/46016/diff/3/?file=1347600#file1347600line210>
> >
> > Use default()
Address in latest patch
- Mugdha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129703
-----------------------------------------------------------
On April 20, 2016, 11:14 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 20, 2016, 11:14 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 658c56f
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py cf56acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py f63d660
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py 4bdbd80
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 4cead39
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/#review129703
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py (line 210)
<https://reviews.apache.org/r/46016/#comment193243>
Use default()
- Jayush Luniya
On April 16, 2016, 8:44 a.m., Mugdha Varadkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46016/
> -----------------------------------------------------------
>
> (Updated April 16, 2016, 8:44 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-15752
> https://issues.apache.org/jira/browse/AMBARI-15752
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add HSM support configuration properties for Ranger KMS in hdp-2.5
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
> ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
> ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
>
> Diff: https://reviews.apache.org/r/46016/diff/
>
>
> Testing
> -------
>
> Installed Ranger KMS centos6.
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
-----------------------------------------------------------
(Updated April 16, 2016, 8:44 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
Changes
-------
Address Jonathan Hurley comment to use default construct
Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752
Repository: ambari
Description
-------
Add HSM support configuration properties for Ranger KMS in hdp-2.5
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
Diff: https://reviews.apache.org/r/46016/diff/
Testing
-------
Installed Ranger KMS centos6.
Thanks,
Mugdha Varadkar
Re: Review Request 46016: AMBARI-15752 Ambari support for additional
config params for Ranger KMS to support HSM
Posted by Mugdha Varadkar <mu...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46016/
-----------------------------------------------------------
(Updated April 15, 2016, 5:34 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jonathan Hurley, Jayush Luniya, and Velmurugan Periasamy.
Changes
-------
Updated patch with changes to avoid plain text in XML file
Ran 253 tests in 7.828s
OK
----------------------------------------------------------------------
Total run:942
Total errors:0
Total failures:0
OK
Bugs: AMBARI-15752
https://issues.apache.org/jira/browse/AMBARI-15752
Repository: ambari
Description
-------
Add HSM support configuration properties for Ranger KMS in hdp-2.5
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/functions/constants.py 86dbc48
ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py 7201c36
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py dd91acf
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py fc722da
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json 03b7e01
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/metainfo.xml 02fb6aa
ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json PRE-CREATION
Diff: https://reviews.apache.org/r/46016/diff/
Testing
-------
Installed Ranger KMS centos6.
Thanks,
Mugdha Varadkar