You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@unomi.apache.org by GitBox <gi...@apache.org> on 2020/07/21 09:22:23 UTC

[GitHub] [unomi] liatiusim opened a new pull request #178: Use profile id on null session

liatiusim opened a new pull request #178:
URL: https://github.com/apache/unomi/pull/178


   Since adding events with profile ID instead of session ID is now supported, it should be supported also when checking if event has already been raised (otherwise null pointer exception will be thrown)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] sergehuber commented on pull request #178: Use profile id if the session id is null when checking if event already raised

Posted by GitBox <gi...@apache.org>.
sergehuber commented on pull request #178:
URL: https://github.com/apache/unomi/pull/178#issuecomment-661752594


   Hello,
   
   Thanks for the fix, is it possible to add an integration test for this? 
   
   Regards,
     Serge... 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] liatiusim closed pull request #178: Use profile id if the session id is null when checking if event already raised

Posted by GitBox <gi...@apache.org>.
liatiusim closed pull request #178:
URL: https://github.com/apache/unomi/pull/178


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [unomi] liatiusim commented on pull request #178: Use profile id if the session id is null when checking if event already raised

Posted by GitBox <gi...@apache.org>.
liatiusim commented on pull request #178:
URL: https://github.com/apache/unomi/pull/178#issuecomment-663985863


   > Pinging again for an integration test.
   > 
   > Thanks
   
   Sure, done


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org