You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dortzur <gi...@git.apache.org> on 2015/04/15 16:37:57 UTC
[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...
GitHub user dortzur opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/85
Fix Android images opening in document viewer
When allowEdit is false, android opens the document viewer instead of photo gallery.
The change uses ACTION_PICK in both cases, fixing the issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dortzur/cordova-plugin-camera master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/85.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #85
----
commit d4fb02630362882d397f738d13b9c47c5d0f8f4e
Author: Dor Tzur <do...@gmail.com>
Date: 2015-04-15T14:34:53Z
Open Photo gallery instead of document viewer
In android, if allowEdit is equal to false while choosing from gallery, the document viewer would open instead of the photo gallery.
The change is that ACTION_PICK is used wether or not allowEdit is enabled.
commit a7c38edd6ad05edbf9fdefe1b0a24a6828961d56
Author: Dor Tzur <do...@gmail.com>
Date: 2015-04-15T14:35:21Z
Merge pull request #1 from dortzur/dortzur-patch-1
Open Photo gallery instead of document viewer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...
Posted by dortzur <gi...@git.apache.org>.
Github user dortzur commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/85#issuecomment-148356598
Nah, I'll probably just wait it out until I can move to React Native.
Thanks anyway.
On Thu, Oct 15, 2015, 13:43 Vladimir Kotikov <no...@github.com>
wrote:
> Shouldn't we use ACTION_GET_CONTENT in both cases instead of ACTION_PICK?
>
> @dortzur <https://github.com/dortzur>, could you please rebase you
> changes before merging.
> Also before we can proceed with merging thi, could you please file it as
> described in CONTRIBUTING.md
> <https://github.com/apache/cordova-plugin-camera/blob/master/CONTRIBUTING.md>
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/cordova-plugin-camera/pull/85#issuecomment-148348112>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/85
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Fix Android images opening in ...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/85#issuecomment-148348112
Shouldn't we use `ACTION_GET_CONTENT` in both cases instead of `ACTION_PICK`?
@dortzur, could you please rebase you changes before merging.
Also before we can proceed with merging thi, could you please file it as described in [CONTRIBUTING.md](https://github.com/apache/cordova-plugin-camera/blob/master/CONTRIBUTING.md)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org