You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@metron.apache.org by ottobackwards <gi...@git.apache.org> on 2018/05/14 21:28:06 UTC

[GitHub] metron pull request #1014: METRON-1563 : Base Stellar assign for feature bra...

GitHub user ottobackwards opened a pull request:

    https://github.com/apache/metron/pull/1014

    METRON-1563 : Base Stellar assign for feature branch

    repackage: 
    https://github.com/apache/metron/pull/687
    
    Please sanity check and see that PR

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ottobackwards/metron stellar_assign

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1014
    
----
commit 37587689e9feadeb54465aa7319f114a4e11255b
Author: cstella <ce...@...>
Date:   2017-12-12T20:24:07Z

    METRON-1306: When index template install fails, we should fail the install closes apache/incubator-metron#834

commit 6ca08b9f598b649d60c6b6468164a374b7f6f555
Author: MohanDV <mo...@...>
Date:   2017-12-13T15:55:04Z

    METRON-1343 Swagger UI for User Controller needs request method (MohanDV via ottobackwards) closes apache/metron#862

commit d9ed1bad1f5b2e2471fbea11353f2947f7f52e13
Author: nickwallen <ni...@...>
Date:   2017-12-14T15:59:27Z

    METRON-1349 Full Dev Builds Metron Twice (nickwallen) closes apache/metron#866

commit c4cee6af64eda4db4da3eff86abab7d4ae4ec56a
Author: mmiklavc <mi...@...>
Date:   2017-12-14T20:29:49Z

    METRON-1345: Update EC2 README for custom Ansible (mmiklavc via mmiklavc) closes apache/metron#859

commit d446da8e707b1069576b049452484e088a3eeede
Author: nickwallen <ni...@...>
Date:   2017-12-19T17:42:39Z

    METRON-1372 Validate JIRA for Releases (nickwallen) closes apache/metron#874

commit adb024070d5d098909fb3800875d0042aeb27c92
Author: ottobackwards <ot...@...>
Date:   2017-12-19T20:13:22Z

    METRON-1374 Script the RC checking process (ottobackwards) closes apache/metron#876

commit 3f0b1b7b4a002d3f364bd2aee7b5921c0435c4a4
Author: cstella <ce...@...>
Date:   2017-12-20T14:30:03Z

    METRON-1350: Add reservoir sampling functions to Stellar closes apache/incubator-metron#867

commit 196da12c43337d019a52b99bf6178fbda45f886d
Author: nickwallen <ni...@...>
Date:   2017-12-21T14:04:49Z

    METRON-1348 Metron Service Checks Use Wrong Hostname (nickwallen) closes apache/metron#864

commit 76bed5d754fcf358809f0be7a034758b9b20fc5e
Author: cstella <ce...@...>
Date:   2017-12-21T21:49:31Z

    METRON-1365: Allow PROFILE_GET to return a default value for a profile and entity that does not have a value written. closes apache/incubator-metron#871

commit 3612a89216bd57c40a1bc3e27853c6146b471e1e
Author: ottobackwards <ot...@...>
Date:   2017-12-25T20:44:45Z

    METRON-1376 RC Check Script should have named parameters (ottobackwards via nickwallen) closes apache/metron#877

commit fc8723e461d655e315d0b51acd1a31f82b4efd1f
Author: nickwallen <ni...@...>
Date:   2017-12-27T18:25:53Z

    METRON-1351 Create Installable Packages for Ubuntu Trusty (nickwallen) closes apache/metron#868

commit 0518408513ed54df8dbe234027b353bed2e61943
Author: mattf-horton <mf...@...>
Date:   2017-12-31T22:01:29Z

    METRON-1373 RAT failure for metron-interface/metron-alerts (mattf-horton) closes apache/metron#875

commit 3b10f84cc49993a1c5917f54be6ca313c8d780c4
Author: justinleet <ju...@...>
Date:   2018-01-01T23:49:57Z

    METRON-1071 Create CONTRIBUTING.md (justinleet) closes apache/metron#881

commit 2d9d7a5f6302267edafba772268145e76751795c
Author: justinleet <ju...@...>
Date:   2018-01-02T16:38:54Z

    METRON-1381 Add Apache license to MD files and remove the Rat exclusion (justinleet) closes apache/metron#883

commit 8a61b96b6b01b247a8ff8d800730378b8da23471
Author: mattf-horton <mf...@...>
Date:   2018-01-02T17:55:52Z

    METRON-1384 Increment master version number to 0.4.3 for on-going development (mattf-horton via nickwallen) closes apache/metron#885

commit 01c26a77b1041204b0bbbc544cc0a5d02e9339a8
Author: nickwallen <ni...@...>
Date:   2018-01-03T14:52:57Z

    METRON-1362 Improve Metron Deployment README (nickwallen) closes apache/metron#869

commit 3381b853dca1c08a7a083593045dec2c7d4d92db
Author: mattf-horton <mf...@...>
Date:   2018-01-04T20:30:30Z

    METRON-1388 update public web site to point at 0.4.2 new release (mattf-horton) closes apache/metron#887

commit 9108072756b6ffeedade985d3cd52ef7338cd61a
Author: merrimanr <me...@...>
Date:   2018-01-08T14:18:30Z

    METRON-1385 Missing &quot;properties&quot; in index template causes ElasticsearchColumnMetadataDao.getColumnMetadata to fail (merrimanr) closes apache/metron#886

commit 0996b7348eca14fea1b1b3c4dd57861b3a30bdeb
Author: cstella <ce...@...>
Date:   2018-01-08T14:30:58Z

    METRON-1377: Stellar function to generate typosquatted domains (similar to dnstwist) closes apache/incubator-metron#878

commit e821391895f0f3523b4e05ae5d639c13b0113855
Author: mmiklavc <mi...@...>
Date:   2018-01-08T19:08:40Z

    METRON-939: Upgrade ElasticSearch and Kibana (mmiklavc via mmiklavc) closes apache/metron#840

commit c559ed7e1838ec71344eae3d9e37771db2641635
Author: cstella <ce...@...>
Date:   2018-01-09T20:28:47Z

    METRON-1379: Add an OBJECT_GET stellar function closes apache/incubator-metron#880

commit 6f869ae55addc884e6734bef72c854db478b6ee4
Author: mmiklavc <mi...@...>
Date:   2018-01-10T17:55:48Z

    METRON-1393: Fix bro Elasticsearch template (mmiklavc via mmiklavc) closes apache/metron#893

commit 43243758cedee803ef610b74b4f42b4ec1d7a1c6
Author: MohanDV <mo...@...>
Date:   2018-01-11T14:56:55Z

    METRON-1390: Swagger UI for "Web Security Config" Controller needs request method (MohanDV via mmiklavc) closes apache/metron#889

commit e127797e63ecd3af2d9aa8fc062e36e28015aac6
Author: cstella <ce...@...>
Date:   2018-01-11T21:45:33Z

    METRON-1366: Add an entropy stellar function (cstella via mmiklavc) closes apache/metron#872

commit 55a737921348514ad7a7d9fab86d169c3b6c3304
Author: justinleet <ju...@...>
Date:   2018-01-12T14:16:35Z

    METRON-1396 Fix .gitignore files to not ignore themselves (justinleet) closes apache/metron#896

commit 2dd01b17782af7756776b8e07afe3661ac19bb0a
Author: nickwallen <ni...@...>
Date:   2018-01-12T18:08:32Z

    METRON-1382 Run Stellar in a Zeppelin Notebook (nickwallen) closes apache/metron#884

commit 6afd95fabf870424177384538ce4685e77fa585c
Author: merrimanr <me...@...>
Date:   2018-01-16T14:35:42Z

    METRON-1231 Separate Sensor name and topic in the Management UI (merrimanr) closes apache/metron#786

commit 5d3e73ab95adf0c8f49c3f821975740e365df91a
Author: cstella <ce...@...>
Date:   2018-01-16T17:31:53Z

    METRON-1378: Create a summarizer closes apache/incubator-metron#879

commit a262f87f0c31637d76a77a538976673c87188eeb
Author: cstella <ce...@...>
Date:   2018-01-16T17:37:59Z

    METRON-1230: As a stopgap prior to METRON-777, add more simplistic sideloading of custom Parsers closes apache/incubator-metron#785

commit 7aa08aef118de330e610cd45d3ac66ed7327439d
Author: cstella <ce...@...>
Date:   2018-01-16T17:40:36Z

    METRON-1380: Create a typosquatting use-case closes apache/incubator-metron#882

----


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    Should assignment be `=` or `:=`?  I'm not super opinionated other than we have been using `:=` and we'd break existing installations if we move to `=`, right?


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by ottobackwards <gi...@git.apache.org>.

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    ok, @cestella I have fixed up the feature branch and this pr so it is clean


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    Ok, this looks good.  +1 to go to the feature branch


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by nickwallen <gi...@git.apache.org>.

Github user nickwallen commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    > Should assignment be = or :=?
    
    Ultimately, I'd like to see us move to supporting `=` as that is just way more intuitive for most people.  Maybe that means supporting both `=` and `:=` for some period of time?
    
    It looks like `StellarAssignment` was not altered here, so maybe both are supported in this PR?  Is that what you are thinking @ottobackwards ?
    
    I am not sure how this PR impacts all the places where Stellar is used and assignment might already occur; field transforms, enrichment,  REPL, profiler, etc.  There is some other way in which assignment is handled in at least some of these places.  I imagine that we would need to update these to use the new mechanism here?  Or maybe that is left to a future PR?
    
    



---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by ottobackwards <gi...@git.apache.org>.

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    This is in, not sure why it isn't closed


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    >Ultimately, I'd like to see us move to supporting = as that is just way more intuitive for most people. Maybe that means supporting both = and := for some period of time?
    
    In my opinion we should support both for at least a release. 


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by ottobackwards <gi...@git.apache.org>.

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    Can I ask how we do ++, --, += etc with the := notation?  


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by ottobackwards <gi...@git.apache.org>.

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    I'll expand the assignment to include := in literal stellar, maybe that will bump some review


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by cestella <gi...@git.apache.org>.

Github user cestella commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    Do we want to expand assignment to `:=` as part of this PR or make it a follow-on in this feature branch?  I'm ok with either way.


---

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

Posted by ottobackwards <gi...@git.apache.org>.

Github user ottobackwards commented on the issue:

    https://github.com/apache/metron/pull/1014
  
    @cestella I rebased this on the new feature branch ( after rebasing on the same master ) and I get all of these other commits.  I don't know how to get rid of them?


---