You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by GitBox <gi...@apache.org> on 2022/05/17 05:38:15 UTC
[GitHub] [struts] lukaszlenart opened a new pull request, #552: [WW-5165] Upgrades Spring to version 5.3.20
lukaszlenart opened a new pull request, #552:
URL: https://github.com/apache/struts/pull/552
Refs [WW-5165](https://issues.apache.org/jira/browse/WW-5165)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] lukaszlenart commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874820794
##########
plugins/portlet/pom.xml:
##########
@@ -130,11 +130,7 @@
<artifactId>spring-test</artifactId>
<optional>true</optional>
</dependency>
- <dependency>
Review Comment:
I know, but the Struts Portlet Plugin depends on it for now - the whole Portel thing is already marked as deprecated and will be gone with the next major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart merged pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
lukaszlenart merged PR #552:
URL: https://github.com/apache/struts/pull/552
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] [struts] sepe81 commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
sepe81 commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874808304
##########
core/pom.xml:
##########
@@ -242,6 +242,16 @@
<artifactId>spring-web</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
Review Comment:
background: Add spring-context for testing with StaticApplicationContext
##########
plugins/portlet-mocks/pom.xml:
##########
@@ -51,6 +51,7 @@
</dependencies>
<properties>
+ <spring.platformVersion>4.3.30.RELEASE</spring.platformVersion>
Review Comment:
good idea, to freeze the spring version here
##########
plugins/portlet/pom.xml:
##########
@@ -130,11 +130,7 @@
<artifactId>spring-test</artifactId>
<optional>true</optional>
</dependency>
- <dependency>
Review Comment:
Maybe we could add some additional infos to the commit to clarify the context
Remove unused spring-webmvc-portlet
Spring 5.x dropped support for spring-webmvc-portlet
https://github.com/spring-projects/spring-framework/wiki/Upgrading-to-Spring-Framework-5.x#dropped-support
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] sepe81 commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
sepe81 commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874827609
##########
core/pom.xml:
##########
@@ -242,6 +242,16 @@
<artifactId>spring-web</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
Review Comment:
I guess, for the test suite to work, this would suffice -- but my comment was just meant as a review note.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874821208
##########
core/pom.xml:
##########
@@ -242,6 +242,16 @@
<artifactId>spring-web</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.springframework</groupId>
+ <artifactId>spring-context</artifactId>
Review Comment:
Do you mean to use `<scope>test</scope>`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [struts] lukaszlenart commented on a diff in pull request #552: [WW-5165] Upgrades Spring to version 5.3.20
Posted by GitBox <gi...@apache.org>.
lukaszlenart commented on code in PR #552:
URL: https://github.com/apache/struts/pull/552#discussion_r874821718
##########
plugins/portlet-mocks/pom.xml:
##########
@@ -51,6 +51,7 @@
</dependencies>
<properties>
+ <spring.platformVersion>4.3.30.RELEASE</spring.platformVersion>
Review Comment:
It's the only way to avoid conflict of dependencies :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org