You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by GitBox <gi...@apache.org> on 2018/12/05 14:23:34 UTC

[GitHub] lburgazzoli commented on a change in pull request #257: chore: add all sorts of linters and pre-commit hook

lburgazzoli commented on a change in pull request #257: chore: add all sorts of linters and pre-commit hook
URL: https://github.com/apache/camel-k/pull/257#discussion_r239083805
 
 

 ##########
 File path: pkg/client/cmd/install.go
 ##########
 @@ -44,9 +44,12 @@ func newCmdInstall(rootCmdOptions *RootCmdOptions) *cobra.Command {
 	cmd.Flags().StringVar(&options.registry, "registry", "", "A Docker registry that can be used to publish images")
 	cmd.Flags().StringVar(&options.organization, "organization", "", "A organization on the Docker registry that can be used to publish images")
 	cmd.Flags().StringVar(&options.pushSecret, "push-secret", "", "A secret used to push images to the Docker registry")
-	cmd.ParseFlags(os.Args)
+	err := cmd.ParseFlags(os.Args)
 
 Review comment:
   @zregvart I think the build problem comes from here: `ParseFlags` is not needed here

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services