You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/11/23 15:32:43 UTC

[GitHub] [spark] srielau commented on a diff in pull request #38707: [SPARK-41176][SQL] Assign a name to the error class _LEGACY_ERROR_TEMP_1042

srielau commented on code in PR #38707:
URL: https://github.com/apache/spark/pull/38707#discussion_r1030587457


##########
core/src/main/resources/error/error-classes.json:
##########
@@ -490,6 +490,11 @@
       "The operation <statement> is not allowed on the <objectType>: <objectName>"
     ]
   },
+  "FUNCTION_WRONG_NUM_ARGS" : {

Review Comment:
   WRONG_NUM_ARGs is fine. If we want to keep a longer name I'd prefer ROUTINE over FUNCTIOn for future proofing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org