You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/01/21 08:47:14 UTC

[GitHub] [pulsar] RobertIndie commented on a change in pull request #9253: [Spotbugs] Enable spotbugs in pulsar-metadata

RobertIndie commented on a change in pull request #9253:
URL: https://github.com/apache/pulsar/pull/9253#discussion_r561695424



##########
File path: pulsar-metadata/src/main/java/org/apache/pulsar/metadata/api/GetResult.java
##########
@@ -26,11 +26,20 @@
 @Data
 public class GetResult {
 
+    public GetResult(byte[] value, Stat stat){
+        this.value = value.clone();

Review comment:
       Maybe we could make the `value` public to solve this problem(`EI_EXPOSE_REP`) and avoid copy, even though that would sacrifice immutability. What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org