[jira] [Commented] (SCM-877) AbstractSvnScmProvider#parseScmUrl() accepts file URLs with backslashes while SvnTagBranchUtils cannot handle them

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SCM-877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420042#comment-16420042 ] 

Michael Osipov commented on SCM-877:
------------------------------------

A branch has been pushed, but unfortunately the fix cannot be applied. As soon as tests run, some SCM plugin mojos fails becaue they use {{basedir}} in {{connectionUrl}} and on Windows it will be {{C:\path\to\repo}} and this is valid. Using {{project.baseUri}} is also not possible because the produced [URI is invalid|https://stackoverflow.com/a/17870390/696632]. Maven core has to switch in that specific part to {{Path}}.

> AbstractSvnScmProvider#parseScmUrl() accepts file URLs with backslashes while SvnTagBranchUtils cannot handle them
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: SCM-877
>                 URL: https://issues.apache.org/jira/browse/SCM-877
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-svn
>    Affects Versions: 1.9.5
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>            Priority: Major
>
> Subversion accepts URLs in the form:
> {noformat}
> svn co file:///D:\my\repo{noformat}
> While this URL is invalid, it is still parsed properly. Using the same URL in {{<developerConnection />}} makes SvnTagBranchUtils completely fail in path calculation because it does not handle backslashes at all.
>  
> The proposed solution is that {{parseUrl()}} will test file URLs for backslashes and reject them since they are invalid anyway.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)