You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zanmato1984 (via GitHub)" <gi...@apache.org> on 2025/01/09 07:47:44 UTC
[PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
zanmato1984 opened a new pull request, #45210:
URL: https://github.com/apache/arrow/pull/45210
<!--
Thanks for opening a pull request!
If this is your first pull request you can find detailed information on how
to contribute here:
* [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/step_by_step/pr_lifecycle.html#reviews-and-merge-of-the-pull-request)
* [Contributing Overview](https://arrow.apache.org/docs/dev/developers/overview.html)
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
-->
### Rationale for this change
I gave the reason in #45209
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
### What changes are included in this PR?
Respect the cmake policy of resolving conflict variables from multiple presets, lift the sanitizer presets above `ninja-debug`.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Manually tested.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
### Are there any user-facing changes?
None.
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please uncomment the line below and explain which changes are breaking.
-->
<!-- **This PR includes breaking changes to public APIs.** -->
<!--
Please uncomment the line below (and provide explanation) if the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld). We use this to highlight fixes to issues that may affect users without their knowledge. For this reason, fixing bugs that cause errors don't count, since those are usually obvious.
-->
<!-- **This PR contains a "Critical Fix".** -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581076998
Hi @kou , I've introduced a group of `_allocator` "mix-in"s. These mix-ins are not to be used as regular inheritance (e.g., `sanitizer`s still specify allocators off for free usage), but rather to override/arbitrate any conflicting variables among different inherited presets (and the underscore prefix makes it the top of the list alphabetically). We can assume that any potential "arbitrator"s in the future (prefixed with underscore as well) won't overlap with each other so the order between them doesn't matter - as long as they are ahead of any non-underscore-prefixed presets, which is true. I think this way, things are less easy to break.
Once it comes to the day that enforcing override ordering is mandatory (let's hope that not!), we can revise these names and introduce number-prefix naming then. How do you think?
Plus, I also did some reordering/regrouping/simplification to existing presets the way I see fit. Please also help to check.
cc @pitrou as well.
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1910084061
##########
cpp/CMakePresets.json:
##########
@@ -274,329 +263,325 @@
{
"name": "ninja-debug-basic",
"inherits": [
- "base-debug",
- "features-basic"
+ "features-basic",
+ "base-debug"
],
"displayName": "Debug build with tests and reduced dependencies",
"cacheVariables": {}
},
{
"name": "ninja-debug",
"inherits": [
- "base-debug",
- "features-main"
+ "features-main",
+ "base-debug"
],
"displayName": "Debug build with tests and more optional components",
"cacheVariables": {}
},
{
"name": "ninja-debug-cuda",
"inherits": [
- "base-debug",
- "features-cuda"
+ "features-cuda",
+ "base-debug"
],
"displayName": "Debug build with tests and CUDA integration",
"cacheVariables": {}
},
{
"name": "ninja-debug-filesystems",
"inherits": [
- "base-debug",
- "features-filesystems"
+ "features-filesystems",
+ "base-debug"
],
"displayName": "Debug build with tests and filesystems",
"cacheVariables": {}
},
{
"name": "ninja-debug-flight",
"inherits": [
- "base-debug",
- "features-flight"
+ "features-flight",
+ "base-debug"
],
"displayName": "Debug build with tests and Flight",
"cacheVariables": {}
},
{
"name": "ninja-debug-flight-sql",
"inherits": [
- "base-debug",
- "features-flight-sql"
+ "features-flight-sql",
+ "base-debug"
],
"displayName": "Debug build with tests and Flight SQL",
"cacheVariables": {}
},
{
"name": "ninja-debug-gandiva",
"inherits": [
- "base-debug",
- "features-gandiva"
+ "features-gandiva",
+ "base-debug"
],
"displayName": "Debug build with tests and Gandiva",
"cacheVariables": {}
},
{
"name": "ninja-debug-python-minimal",
"inherits": [
- "base-debug",
- "features-python-minimal"
+ "features-python-minimal",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with minimal features",
"cacheVariables": {}
},
{
"name": "ninja-debug-python",
"inherits": [
- "base-debug",
- "features-python"
+ "features-python",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with common features (for backward compatibility)",
"cacheVariables": {}
},
{
"name": "ninja-debug-python-maximal",
"inherits": [
- "base-debug",
- "features-python-maximal"
+ "features-python-maximal",
+ "base-debug"
],
"displayName": "Debug build for PyArrow with everything enabled",
"cacheVariables": {}
},
{
"name": "ninja-debug-maximal",
"inherits": [
- "base-debug",
- "features-maximal"
+ "features-maximal",
+ "base-debug"
],
"displayName": "Debug build with everything enabled (except benchmarks)",
"cacheVariables": {}
},
+ {
+ "name": "ninja-debug-emscripten",
+ "inherits": [
+ "features-emscripten",
+ "base-debug"
+ ],
+ "displayName": "Debug build which builds an Emscripten library",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind-minimal",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug-minimal"
+ ],
+ "displayName": "Debug build for Valgrind without anything enabled",
+ "cacheVariables": {}
+ },
{
"name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-basic",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build for Valgrind with tests and reduced dependencies",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind with tests and more optional components",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and everything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-maximal",
+ "name": "ninja-debug-asan",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "sanitizer-asan",
+ "ninja-debug"
],
- "displayName": "Debug build for Valgrind with everything enabled",
+ "displayName": "Debug build for ASAN with tests and more optional components",
"cacheVariables": {}
},
{
- "name": "ninja-release-minimal",
+ "name": "ninja-debug-tsan",
"inherits": [
- "base-release",
- "features-minimal"
+ "sanitizer-tsan",
+ "ninja-debug"
],
- "displayName": "Release build without anything enabled",
+ "displayName": "Debug build for TSAN with tests and more optional components",
"cacheVariables": {}
},
{
- "name": "ninja-release-basic",
+ "name": "ninja-debug-ubsan",
"inherits": [
- "base-release",
- "features-basic"
+ "sanitizer-ubsan",
+ "ninja-debug"
],
- "displayName": "Release build with reduced dependencies",
+ "displayName": "Debug build for UBSAN with tests and more optional components",
"cacheVariables": {}
},
{
- "name": "ninja-release",
+ "name": "fuzzing",
"inherits": [
- "base-release",
- "features-main"
+ "base",
+ "sanitizer-asan",
+ "sanitizer-ubsan"
Review Comment:
```suggestion
"sanitizer-asan",
"sanitizer-ubsan",
"base"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581974215
Thank you so much for the confirmation.
> In general, we should use `sanitizers-*` -> `features-*` -> `base-*` order to avoid this problem, right?
Yes, that seems to be the general rule for inheritance.
> I think that `0-sanitizer-*`, `1-features-*`, `base-*` is better but it's not a strong opinion. If you like non-alphabetical order, I'm OK with it.
I personally think introducing number prefix could be a bit overkill. And hope that the repeating occurrences of `sanitizers-*` -> `features-*` -> `base-*` pattern will hint people enough to realize that this is the intended order (though we can't really mandate it). Once we upgrade to cmake that is new enough to support comments, then we can add some description then.
I'll rework the PR, keeping the non-related refinement, and reducing the ordering stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909758781
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
Yeah that makes much more sense. Updated. Also changed to use plural `_allocators`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579592652
> Hmm. This will be easy to break... Because we want to sort lists in general and we can't add comments in JSON.
>
> How about creating `000-disable-allocators` or something preset and use it instead?
Ah, that sounds nice. I'll try it and update soon. Thank you for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582004811
Revision: 7150e71f2db39a5ba16ea155646ab741baa44aaa
Submitted crossbow builds: [ursacomputing/crossbow @ actions-8d07c78518](https://github.com/ursacomputing/crossbow/branches/all?query=actions-8d07c78518)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561901/job/35416813560)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562530/job/35416815885)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562611/job/35416815987)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562368/job/35416814994)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562457/job/35416815193)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562084/job/35416814520)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562298/job/35416815025)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562120/job/35416814429)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562439/job/35416815623)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562520/job/35416815959)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562284/job/35416814995)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562274/job/35416814974)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561986/job/35416813932)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561894/job/35416813558)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562763/job/35416816686)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562818/job/35416816679)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562018/job/35416813971)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561899/job/35416813537)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562708/job/35416816654)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562512/job/35416815616)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562585/job/35416815856)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12705562086/job/35416814446)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561959/job/35416813546)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12705561928/job/35416813789)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909703496
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Thank you for the idea. But unfortunately `"$comment"` is only supported in version 10 or above, and version 10 is only supported since cmake 3.31.
From the link you provided.
> Preset files specifying version 10 or above may include comments using the key $comment at any level within the JSON object to provide documentation.
> 10 Added in version 3.31.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579577972
Hmm. This will be easy to break... Because we want to sort lists in general and we can't add comments in JSON.
How about creating `000-disable-allocators` or something preset and use it instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581812481
Revision: 20da6bfe87b64d52a6e9b70228d3a95bcd7fda16
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a28de98f4d](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a28de98f4d)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12703892034/job/35412389950)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891550/job/35412389277)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891402/job/35412387895)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891364/job/35412387945)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891344/job/35412388041)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891355/job/35412388419)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891410/job/35412388096)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891494/job/35412388969)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891657/job/35412389896)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891609/job/35412389733)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891546/job/35412389226)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891346/job/35412388078)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891475/job/35412388968)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891582/job/35412389712)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891943/job/35412389942)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891684/job/35412389455)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891483/job/35412389022)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891451/job/35412388412)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891340/job/35412387928)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891354/job/35412387914)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891643/job/35412389746)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891641/job/35412389740)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891338/job/35412388418)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12703891476/job/35412388405)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581810278
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579367945
cc @kou @wgtmac . My apology for not thoroughly testing my last PR and having to make this patch. Would you please take a look again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 merged PR #45210:
URL: https://github.com/apache/arrow/pull/45210
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909741407
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
OK. Let's use the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582001375
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581680584
Could you update the PR description before you merge this?
We need to describe why we have `_XXX`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582092033
Revision: 424a9a2ab145cf2b23a5c95373fa2c33bea3ebb4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-06bc23cb35](https://github.com/ursacomputing/crossbow/branches/all?query=actions-06bc23cb35)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272588/job/35418900681)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272845/job/35418901440)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272287/job/35418899154)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272103/job/35418898461)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272448/job/35418900046)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272465/job/35418900098)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272441/job/35418899895)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272911/job/35418941699)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272797/job/35418901273)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272394/job/35418899469)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272399/job/35418899474)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272070/job/35418898344)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272374/job/35418899617)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272291/job/35418898860)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272782/job/35418901153)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272414/job/35418899839)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272503/job/35418900245)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272028/job/35418898205)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272269/job/35418898848)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272332/job/35418899339)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272305/job/35418898880)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272602/job/35418900712)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12706271942/job/35418897954)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272608/job/35418900727)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272699/job/35418901025)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272500/job/35418900108)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272749/job/35418901069)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272442/job/35418900025)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272212/job/35418898634)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12706272535/job/35418900274)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582086228
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582205377
PR description updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909720287
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
Ahh, I see.
However I think we are expecting these allocator presets to enforce the allocator selection. That is, `_allocator_X` should mean "only enable allocator X, nothing else".
So for intentionally enabling both selectors, we can have another `_allocator_all` maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909708237
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Oh...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581812799
Revision: 20da6bfe87b64d52a6e9b70228d3a95bcd7fda16
Submitted crossbow builds: [ursacomputing/crossbow @ actions-489c8994f2](https://github.com/ursacomputing/crossbow/branches/all?query=actions-489c8994f2)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894873/job/35412396098)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895002/job/35412396671)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894887/job/35412396240)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894947/job/35412396476)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895234/job/35412397877)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895147/job/35412397597)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895027/job/35412396918)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894951/job/35412396474)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894996/job/35412396745)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895174/job/35412397661)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895108/job/35412397255)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895094/job/35412397057)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895181/job/35412397748)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894892/job/35412396246)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895372/job/35412423631)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895091/job/35412397262)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894958/job/35412396635)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895470/job/35412423646)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895093/job/35412397142)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894828/job/35412395985)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895117/job/35412397490)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894995/job/35412396741)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895034/job/35412397032)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895469/job/35412423670)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895166/job/35412397641)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895095/job/35412397143)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12703894943/job/35412396439)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895113/job/35412397364)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895276/job/35412397999)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12703895144/job/35412397412)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582082040
@github-actions crossbow submit -g cpp python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909720287
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
Ahh, I see.
However I think we are expecting these allocator presets to enforce the allocator selection. That is, `_allocator_X` should mean "only enable allocator X, nothing else".
So for intentionally enabling both allocators, we can have another `_allocator_all` maybe?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2579366374
:warning: GitHub issue #45209 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909637693
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
Do we need this?
How about specifying only `ARROW_JEMALLOC` here?
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
"PARQUET_REQUIRE_ENCRYPTION": "ON"
}
},
{
"name": "features-maximal",
"inherits": [
- "features-main",
- "features-cuda",
- "features-filesystems",
- "features-flight-sql",
- "features-gandiva",
"features-python-maximal"
],
"hidden": true,
"cacheVariables": {
"ARROW_BUILD_EXAMPLES": "ON",
"ARROW_BUILD_UTILITIES": "ON",
- "ARROW_ORC": "ON",
"ARROW_SKYHOOK": "ON",
"ARROW_TENSORFLOW": "ON",
"PARQUET_BUILD_EXAMPLES": "ON",
- "PARQUET_BUILD_EXECUTABLES": "ON",
- "PARQUET_REQUIRE_ENCRYPTION": "ON"
+ "PARQUET_BUILD_EXECUTABLES": "ON"
+ }
+ },
+ {
+ "name": "features-emscripten",
Review Comment:
Can we inherit `_allocator-none` here?
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
Review Comment:
ditto.
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Can we use this in `features-minimal` too?
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
Review Comment:
Can we use this in `features-basic`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909705887
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
"PARQUET_REQUIRE_ENCRYPTION": "ON"
}
},
{
"name": "features-maximal",
"inherits": [
- "features-main",
- "features-cuda",
- "features-filesystems",
- "features-flight-sql",
- "features-gandiva",
"features-python-maximal"
],
"hidden": true,
"cacheVariables": {
"ARROW_BUILD_EXAMPLES": "ON",
"ARROW_BUILD_UTILITIES": "ON",
- "ARROW_ORC": "ON",
"ARROW_SKYHOOK": "ON",
"ARROW_TENSORFLOW": "ON",
"PARQUET_BUILD_EXAMPLES": "ON",
- "PARQUET_BUILD_EXECUTABLES": "ON",
- "PARQUET_REQUIRE_ENCRYPTION": "ON"
+ "PARQUET_BUILD_EXECUTABLES": "ON"
+ }
+ },
+ {
+ "name": "features-emscripten",
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909297730
##########
cpp/CMakePresets.json:
##########
@@ -46,34 +70,6 @@
"CMAKE_BUILD_TYPE": "RelWithDebInfo"
}
},
- {
Review Comment:
Adjusting order.
##########
cpp/CMakePresets.json:
##########
@@ -174,15 +169,11 @@
{
"name": "features-python",
"inherits": [
- "features-main"
+ "features-main",
+ "features-python-minimal"
Review Comment:
Inheriting to avoid duplicating variables.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
Review Comment:
Adjusting order to minimal -> basic -> main (omitted) -> maximal.
Also inheriting `ninja-debug-xxx` to replace `base-debug` + `features-xxx`.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
+ ],
+ "displayName": "Debug build for Valgrind with tests and everything enabled",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-asan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-asan"
+ ],
+ "displayName": "Debug build for ASAN with tests and more optional components",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-tsan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-tsan"
+ ],
+ "displayName": "Debug build for TSAN with tests and more optional components",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-ubsan",
+ "inherits": [
+ "_allocator-none",
+ "ninja-debug",
+ "sanitizer-ubsan"
],
- "displayName": "Debug build for Valgrind with everything enabled",
+ "displayName": "Debug build for UBSAN with tests and more optional components",
"cacheVariables": {}
},
+ {
Review Comment:
Moved from the bottom of the file to after `sanitizer` group because it also belongs to `debug` group.
##########
cpp/CMakePresets.json:
##########
@@ -103,7 +99,6 @@
"cacheVariables": {
"ARROW_SUBSTRAIT": "ON",
"ARROW_ACERO": "ON",
- "ARROW_MIMALLOC": "ON",
Review Comment:
Removing duplication.
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
Review Comment:
Reduce duplication.
##########
cpp/CMakePresets.json:
##########
@@ -446,24 +508,6 @@
"displayName": "Release build with CUDA integration",
"cacheVariables": {}
},
- {
- "name": "ninja-debug-emscripten",
- "inherits": [
- "features-emscripten",
- "base-debug"
- ],
- "displayName": "Debug build which builds an Emscripten library",
- "cacheVariables": {}
- },
- {
- "name": "ninja-release-emscripten",
- "inherits": [
- "features-emscripten",
- "base-release"
- ],
- "displayName": "Release build which builds an Emscripten library",
- "cacheVariables": {}
- },
Review Comment:
Moved to after couple of "common" features within release group.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
- "features-basic",
- "features-valgrind"
+ "features-emscripten"
],
- "displayName": "Debug build for Valgrind with reduced dependencies",
+ "displayName": "Debug build which builds an Emscripten library",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind",
+ "name": "ninja-debug-valgrind-minimal",
"inherits": [
- "base-debug",
- "features-main",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-minimal"
],
- "displayName": "Debug build for Valgrind with more optional components",
+ "displayName": "Debug build for Valgrind without anything enabled",
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-minimal",
+ "name": "ninja-debug-valgrind-basic",
"inherits": [
- "base-debug",
- "features-minimal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-basic"
],
- "displayName": "Debug build for Valgrind without anything enabled",
+ "displayName": "Debug build for Valgrind with tests and reduced dependencies",
+ "cacheVariables": {}
+ },
+ {
+ "name": "ninja-debug-valgrind",
+ "inherits": [
+ "features-valgrind",
+ "ninja-debug"
+ ],
+ "displayName": "Debug build for Valgrind with tests and more optional components",
"cacheVariables": {}
},
{
"name": "ninja-debug-valgrind-maximal",
"inherits": [
- "base-debug",
- "features-maximal",
- "features-valgrind"
+ "features-valgrind",
+ "ninja-debug-maximal"
+ ],
+ "displayName": "Debug build for Valgrind with tests and everything enabled",
+ "cacheVariables": {}
+ },
+ {
Review Comment:
Moved `ninja-debug-[sanitizer]` group here after valgrind group.
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
"PARQUET_REQUIRE_ENCRYPTION": "ON"
}
},
{
"name": "features-maximal",
"inherits": [
- "features-main",
- "features-cuda",
- "features-filesystems",
- "features-flight-sql",
- "features-gandiva",
"features-python-maximal"
],
"hidden": true,
"cacheVariables": {
"ARROW_BUILD_EXAMPLES": "ON",
"ARROW_BUILD_UTILITIES": "ON",
- "ARROW_ORC": "ON",
"ARROW_SKYHOOK": "ON",
"ARROW_TENSORFLOW": "ON",
"PARQUET_BUILD_EXAMPLES": "ON",
- "PARQUET_BUILD_EXECUTABLES": "ON",
- "PARQUET_REQUIRE_ENCRYPTION": "ON"
Review Comment:
Reduce duplication.
##########
cpp/CMakePresets.json:
##########
@@ -371,45 +381,97 @@
"cacheVariables": {}
},
{
- "name": "ninja-debug-valgrind-basic",
+ "name": "ninja-debug-emscripten",
Review Comment:
Adjusting order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909752942
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
Can we use it for `features-maximal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581951292
Hmm. I'm OK with it if we can use comment in the JSON...
In general, we should use `sanitizers-*` -> `features-*` -> `base-*` order to avoid this problem, right?
I think that `0-sanitizer-*`, `1-features-*`, `base-*` is better but it's not a strong opinion. If you like non-alphabetical order, I'm OK with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582084044
```
Unable to match any tasks for `python`
The Archery job run can be found at: https://github.com/apache/arrow/actions/runs/12706221844
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909639832
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
It seems that we can add comments by `"$comment"`: https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#format
Could you add a comment why we use `_XXX` name here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909712125
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
We can enable multiple allocators at the same time. :-)
The default allocator is chosen based on our recommendation:
https://github.com/apache/arrow/blob/5181c24f6d780591426e0af0d1b72c68f190484c/cpp/src/arrow/memory_pool.cc#L143
https://github.com/apache/arrow/blob/5181c24f6d780591426e0af0d1b72c68f190484c/cpp/src/arrow/memory_pool.cc#L86-L100
But users can select any allocator from enabled allocators by creating `arrow::MemoryPool` instead of using `arrow::default_memory_pool()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582006531
Revision: 7150e71f2db39a5ba16ea155646ab741baa44aaa
Submitted crossbow builds: [ursacomputing/crossbow @ actions-212fbf47c1](https://github.com/ursacomputing/crossbow/branches/all?query=actions-212fbf47c1)
|Task|Status|
|----|------|
|example-python-minimal-build-fedora-conda|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564050/job/35416820784)|
|example-python-minimal-build-ubuntu-venv|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564073/job/35416821554)|
|test-conda-python-3.10|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563832/job/35416819997)|
|test-conda-python-3.10-cython2|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563990/job/35416820973)|
|test-conda-python-3.10-hdfs-2.9.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563771/job/35416819922)|
|test-conda-python-3.10-hdfs-3.2.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563944/job/35416820808)|
|test-conda-python-3.10-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563978/job/35416820763)|
|test-conda-python-3.10-substrait|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563715/job/35416819682)|
|test-conda-python-3.11|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563776/job/35416819566)|
|test-conda-python-3.11-dask-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564253/job/35416859227)|
|test-conda-python-3.11-dask-upstream_devel|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563722/job/35416819909)|
|test-conda-python-3.11-hypothesis|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564067/job/35416821556)|
|test-conda-python-3.11-pandas-latest-numpy-1.26|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563489/job/35416818752)|
|test-conda-python-3.11-pandas-latest-numpy-latest|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563948/job/35416821003)|
|test-conda-python-3.11-pandas-nightly-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563712/job/35416820124)|
|test-conda-python-3.11-pandas-upstream_devel-numpy-nightly|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563836/job/35416820193)|
|test-conda-python-3.11-spark-master|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563880/job/35416820511)|
|test-conda-python-3.12|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563620/job/35416818960)|
|test-conda-python-3.12-cpython-debug|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564083/job/35416821721)|
|test-conda-python-3.13|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563987/job/35416820778)|
|test-conda-python-3.9|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563713/job/35416819684)|
|test-conda-python-3.9-pandas-1.1.3-numpy-1.19.5|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564289/job/35416859249)|
|test-conda-python-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564351/job/35416859321)|
|test-cuda-python-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563559/job/35416818742)|
|test-debian-12-python-3-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563786/job/35416819770)|
|test-debian-12-python-3-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563577/job/35416819060)|
|test-fedora-39-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563592/job/35416818963)|
|test-ubuntu-22.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564227/job/35416859240)|
|test-ubuntu-22.04-python-313-freethreading|[](https://github.com/ursacomputing/crossbow/actions/runs/12705564059/job/35416821382)|
|test-ubuntu-24.04-python-3|[](https://github.com/ursacomputing/crossbow/actions/runs/12705563774/job/35416820168)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582001169
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582932276
The CI failures are not related. Merging.
I appreciate the comments and help from @kou , thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581918284
Hi @kou , sorry to bother you again.
The test-ubuntu-22.04-cpp-emscripten failure is related, because the reordering from
```
"name": "ninja-debug-emscripten",
"inherits": [
"features-emscripten",
"base-debug"
],
```
to
```
"name": "ninja-debug-emscripten",
"inherits": [
"base-debug",
"features-emscripten"
],
```
messed up the `ARROW_BUILD_STATIC` (set to `OFF` in `base-debug` and to `ON` in `features-emscripten`). This is essentially the same issue as the one the PR is trying to fix.
We can again tune the overriding of `ARROW_BUILD_STATIC` using the same way we did for allocators. However I want to take a step back considering about this question: if the order of elements in a list matters functionally, maybe we shouldn't enforce the alphabetical order at all? What do you think? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582091387
Revision: 424a9a2ab145cf2b23a5c95373fa2c33bea3ebb4
Submitted crossbow builds: [ursacomputing/crossbow @ actions-1e52e8655b](https://github.com/ursacomputing/crossbow/branches/all?query=actions-1e52e8655b)
|Task|Status|
|----|------|
|example-cpp-minimal-build-static|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269241/job/35418890123)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269164/job/35418890153)|
|example-cpp-tutorial|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269553/job/35418891522)|
|test-alpine-linux-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269396/job/35418890693)|
|test-build-cpp-fuzz|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269483/job/35418891170)|
|test-conda-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269573/job/35418891558)|
|test-conda-cpp-valgrind|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269591/job/35418891672)|
|test-cuda-cpp-ubuntu-20.04-cuda-11.2.2|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269882/job/35418892562)|
|test-cuda-cpp-ubuntu-22.04-cuda-11.7.1|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269728/job/35418892094)|
|test-debian-12-cpp-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269517/job/35418891169)|
|test-debian-12-cpp-i386|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269362/job/35418890681)|
|test-fedora-39-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269803/job/35418892239)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269442/job/35418890876)|
|test-ubuntu-20.04-cpp-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269721/job/35418892003)|
|test-ubuntu-22.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269296/job/35418890553)|
|test-ubuntu-22.04-cpp-20|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269252/job/35418890141)|
|test-ubuntu-22.04-cpp-emscripten|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269162/job/35418890144)|
|test-ubuntu-22.04-cpp-no-threading|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269727/job/35418892017)|
|test-ubuntu-24.04-cpp|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269791/job/35418892178)|
|test-ubuntu-24.04-cpp-bundled-offline|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269525/job/35418891186)|
|test-ubuntu-24.04-cpp-gcc-13-bundled|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269581/job/35418891633)|
|test-ubuntu-24.04-cpp-gcc-14|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269498/job/35418891157)|
|test-ubuntu-24.04-cpp-minimal-with-formats|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269436/job/35418890835)|
|test-ubuntu-24.04-cpp-thread-sanitizer|[](https://github.com/ursacomputing/crossbow/actions/runs/12706269789/job/35418892223)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909746061
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
But is `_allocator_all` useful enough to worth an individual cmake preset? (It makes the `_allocator` group intact though).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581809975
@github-actions crossbow submit -g cpp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909654742
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Hmm, yes we can. I was trying to add some specialty to `_` presets, that is, not using it in regular inheritance where there is no conflicting variables. However I think nothing functional really prevents it from being used in regular inheritance. I'll try that and update soon.
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
Review Comment:
You mean something like this?
```suggestion
```
I think we should always specify one `ON` one `OFF` together (unless we are 100% sure about one value of them being specified earlier) - otherwise there could be potentially two allocators which is not desired?
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
Review Comment:
Answered in my other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909670361
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
Review Comment:
As replied in my other comment, yes we can. Will try.
##########
cpp/CMakePresets.json:
##########
@@ -193,35 +184,54 @@
"features-filesystems",
"features-flight-sql",
"features-gandiva",
- "features-main",
- "features-python-minimal"
+ "features-python"
],
"hidden": true,
"cacheVariables": {
- "ARROW_ORC": "ON",
"PARQUET_REQUIRE_ENCRYPTION": "ON"
}
},
{
"name": "features-maximal",
"inherits": [
- "features-main",
- "features-cuda",
- "features-filesystems",
- "features-flight-sql",
- "features-gandiva",
"features-python-maximal"
],
"hidden": true,
"cacheVariables": {
"ARROW_BUILD_EXAMPLES": "ON",
"ARROW_BUILD_UTILITIES": "ON",
- "ARROW_ORC": "ON",
"ARROW_SKYHOOK": "ON",
"ARROW_TENSORFLOW": "ON",
"PARQUET_BUILD_EXAMPLES": "ON",
- "PARQUET_BUILD_EXECUTABLES": "ON",
- "PARQUET_REQUIRE_ENCRYPTION": "ON"
+ "PARQUET_BUILD_EXECUTABLES": "ON"
+ }
+ },
+ {
+ "name": "features-emscripten",
Review Comment:
Yeah.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on code in PR #45210:
URL: https://github.com/apache/arrow/pull/45210#discussion_r1909706410
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
Review Comment:
Addressed.
##########
cpp/CMakePresets.json:
##########
@@ -6,6 +6,30 @@
"patch": 0
},
"configurePresets": [
+ {
+ "name": "_allocator-none",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "OFF",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-jemalloc",
+ "hidden": true,
+ "cacheVariables": {
+ "ARROW_JEMALLOC": "ON",
+ "ARROW_MIMALLOC": "OFF"
+ }
+ },
+ {
+ "name": "_allocator-mimalloc",
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2581693345
> Could you update the PR description before you merge this? We need to describe why we have `_XXX`.
Updated, thanks.
I'll also do some final verification for this change later before merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2593339874
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit d0b11bb14712fd351bea3e29719afb5c4d278619.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/35662605532) has more details. It also includes information about 2 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582086681
@github-actions crossbow submit -g python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-45209: [C++][CMake] Fix the issue that allocator not disabled for sanitizer cmake presets [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45210:
URL: https://github.com/apache/arrow/pull/45210#issuecomment-2582114465
I've refined the code and validated that all the variables set in each preset are as expected.
Other than the allocators being disabled for sanitizer presets (as intended), there is another diff for `ninja-debug-valgrind-minimal` with `ARROW_BUILD_INTEGRATION` and `ARROW_BUILD_TESTS` changed from `ON` to `OFF`, which IMO is correct. I've also updated the PR description.
@kou would you mind to look again? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org