You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "abcxyz333 (via GitHub)" <gi...@apache.org> on 2026/05/06 03:46:33 UTC
Re: [PR] [feature](dynamic table) support stream part 2: stream query & comsuption infrastructure [doris]
abcxyz333 commented on code in PR #62453:
URL: https://github.com/apache/doris/pull/62453#discussion_r3192869062
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/logical/LogicalOlapTableStreamScan.java:
##########
@@ -0,0 +1,270 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.logical;
+
+import org.apache.doris.catalog.Column;
+import org.apache.doris.catalog.OlapTable;
+import org.apache.doris.catalog.Table;
+import org.apache.doris.common.IdGenerator;
+import org.apache.doris.nereids.memo.GroupExpression;
+import org.apache.doris.nereids.properties.LogicalProperties;
+import org.apache.doris.nereids.properties.OrderKey;
+import org.apache.doris.nereids.trees.TableSample;
+import org.apache.doris.nereids.trees.expressions.Alias;
+import org.apache.doris.nereids.trees.expressions.ExprId;
+import org.apache.doris.nereids.trees.expressions.NamedExpression;
+import org.apache.doris.nereids.trees.expressions.Slot;
+import org.apache.doris.nereids.trees.expressions.SlotReference;
+import org.apache.doris.nereids.trees.expressions.StatementScopeIdGenerator;
+import org.apache.doris.nereids.trees.expressions.literal.BigIntLiteral;
+import org.apache.doris.nereids.trees.expressions.literal.VarcharLiteral;
+import org.apache.doris.nereids.trees.plans.AbstractPlan;
+import org.apache.doris.nereids.trees.plans.PreAggStatus;
+import org.apache.doris.nereids.trees.plans.RelationId;
+import org.apache.doris.nereids.trees.plans.ScoreRangeInfo;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Lists;
+import com.google.common.collect.Maps;
+import org.apache.commons.lang3.tuple.Pair;
+
+import java.util.Collection;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+
+/**
+ * Logical OlapTableStreamScan
+ */
+public class LogicalOlapTableStreamScan extends LogicalOlapScan {
+ private boolean isIncrementalScan = false;
+
+ /**
+ * LogicalOlapTableStreamScan construct method
+ */
+ public LogicalOlapTableStreamScan(RelationId id, OlapTable table, List<String> qualifier, List<Long> tabletIds,
+ List<String> hints, Optional<TableSample> tableSample, Collection<Slot> operativeSlots) {
+ super(id, table, qualifier, tabletIds, hints, tableSample, operativeSlots);
+ }
+
+ /**
+ * LogicalOlapTableStreamScan construct method
+ */
+ public LogicalOlapTableStreamScan(RelationId id, OlapTable table, List<String> qualifier,
+ List<Long> specifiedPartitions, List<Long> tabletIds, List<String> hints,
+ Optional<TableSample> tableSample, List<Slot> operativeSlots) {
+ super(id, table, qualifier, specifiedPartitions, tabletIds, hints, tableSample, operativeSlots);
+ }
+
+ /**
+ * LogicalOlapTableStreamScan construct method
+ */
+ public LogicalOlapTableStreamScan(RelationId id, Table table, List<String> qualifier,
+ Optional<GroupExpression> groupExpression,
+ Optional<LogicalProperties> logicalProperties,
+ List<Long> selectedPartitionIds, boolean partitionPruned,
+ List<Long> selectedTabletIds, long selectedIndexId, boolean indexSelected,
+ PreAggStatus preAggStatus, List<Long> specifiedPartitions,
+ List<String> hints, Map<Pair<Long, String>, Slot> cacheSlotWithSlotName,
+ Optional<List<Slot>> cachedOutput, Optional<TableSample> tableSample,
+ boolean directMvScan,
+ Map<String, Set<List<String>>> colToSubPathsMap, List<Long> specifiedTabletIds,
+ Collection<Slot> operativeSlots, List<NamedExpression> virtualColumns,
+ List<OrderKey> scoreOrderKeys, Optional<Long> scoreLimit,
+ Optional<ScoreRangeInfo> scoreRangeInfo,
+ List<OrderKey> annOrderKeys, Optional<Long> annLimit, String tableAlias) {
+ super(id, table, qualifier, groupExpression, logicalProperties,
+ selectedPartitionIds, partitionPruned, selectedTabletIds, selectedIndexId, indexSelected,
+ preAggStatus, specifiedPartitions, hints, cacheSlotWithSlotName, cachedOutput, tableSample,
+ directMvScan, colToSubPathsMap, specifiedTabletIds, operativeSlots, virtualColumns,
+ scoreOrderKeys, scoreLimit, scoreRangeInfo, annOrderKeys, annLimit, tableAlias);
+ }
+
+ @Override
+ public LogicalOlapTableStreamScan withManuallySpecifiedTabletIds(List<Long> manuallySpecifiedTabletIds) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ Optional.empty(), Optional.of(getLogicalProperties()),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, cachedOutput, tableSample, directMvScan,
+ colToSubPathsMap, manuallySpecifiedTabletIds, operativeSlots, virtualColumns,
+ scoreOrderKeys, scoreLimit, scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ @Override
+ public List<Slot> computeOutput() {
+ if (cachedOutput.isPresent()) {
+ return cachedOutput.get();
+ }
+ // we need to create slots vectorized for stream scan, no need for invisible column
+ // todo(TsukiokaKogane): support compute binlog-based schema
+ List<Column> baseSchema = table.getBaseSchema(false);
+ List<SlotReference> slotFromColumn = createSlotsVectorized(baseSchema);
+
+ ImmutableList.Builder<Slot> slots = ImmutableList.builder();
+ IdGenerator<ExprId> exprIdGenerator = StatementScopeIdGenerator.getExprIdGenerator();
+ for (int i = 0; i < baseSchema.size(); i++) {
+ final int index = i;
+ Column col = baseSchema.get(i);
+ Pair<Long, String> key = Pair.of(selectedIndexId, col.getName());
+ Slot slot = cacheSlotWithSlotName.computeIfAbsent(key, k -> slotFromColumn.get(index));
+ slots.add(slot);
+ if (colToSubPathsMap.containsKey(key.getValue())) {
+ for (List<String> subPath : colToSubPathsMap.get(key.getValue())) {
+ if (!subPath.isEmpty()) {
+ SlotReference slotReference = SlotReference.fromColumn(
+ exprIdGenerator.getNextId(), table, baseSchema.get(i), qualified()
+ ).withSubPath(subPath);
+ slots.add(slotReference);
+ subPathToSlotMap.computeIfAbsent(slot, k -> Maps.newHashMap())
+ .put(subPath, slotReference);
+ }
+ }
+ }
+ }
+ if (!isIncrementalScan) {
+ // inject virtual stream hidden columns
+ SlotReference seqColRef = (SlotReference) new Alias(new BigIntLiteral(-1L), Column.STREAM_SEQ_COL).toSlot();
+ slots.add(seqColRef.withColumn(Column.STREAM_SEQ_VIRTUAL_COLUMN));
+ SlotReference changeTypeColRef = (SlotReference) new Alias(new VarcharLiteral("APPEND"),
+ Column.STREAM_CHANGE_TYPE_COL).toSlot();
+ slots.add(changeTypeColRef.withColumn(Column.STREAM_CHANGE_TYPE_VIRTUAL_COLUMN));
+ }
+ for (NamedExpression virtualColumn : virtualColumns) {
+ slots.add(virtualColumn.toSlot());
+ }
+ return slots.build();
+ }
+
+ /**
+ * withSelectedTabletIds
+ */
+ @Override
+ public LogicalOlapTableStreamScan withSelectedTabletIds(List<Long> selectedTabletIds) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ Optional.empty(), Optional.of(getLogicalProperties()),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, cachedOutput, tableSample, directMvScan,
+ colToSubPathsMap, manuallySpecifiedTabletIds, operativeSlots, virtualColumns, scoreOrderKeys,
+ scoreLimit, scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ /** withCachedOutput */
+ @Override
+ public LogicalOlapTableStreamScan withCachedOutput(List<Slot> outputSlots) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ groupExpression, Optional.empty(),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions, hints,
+ cacheSlotWithSlotName, Optional.of(outputSlots), tableSample, directMvScan, colToSubPathsMap,
+ manuallySpecifiedTabletIds, operativeSlots, virtualColumns, scoreOrderKeys, scoreLimit,
+ scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ @Override
+ public LogicalOlapTableStreamScan withOperativeSlots(Collection<Slot> operativeSlots) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ groupExpression, Optional.of(getLogicalProperties()),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, cachedOutput, tableSample, directMvScan, colToSubPathsMap,
+ manuallySpecifiedTabletIds, operativeSlots, virtualColumns, scoreOrderKeys, scoreLimit,
+ scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ @Override
+ public List<Slot> getOutputByIndex(long indexId) {
+ // we need to create slots vectorized for stream scan, no need for invisible column
+ OlapTable olapTable = (OlapTable) table;
+ // PhysicalStorageLayerAggregateTest has no visible index
+ // when we have a partitioned table without any partition, visible index is
+ // empty
+ List<Column> schema = olapTable.getIndexMetaByIndexId(indexId).getSchema();
+ List<Slot> slots = Lists.newArrayListWithCapacity(schema.size());
+ IdGenerator<ExprId> exprIdGenerator = StatementScopeIdGenerator.getExprIdGenerator();
+ for (Column c : schema) {
+ slots.addAll(generateUniqueSlot(
+ olapTable, c, indexId == ((OlapTable) table).getBaseIndexId(), indexId, exprIdGenerator
+ ));
+ }
+ // add virtual slots, TODO: maybe wrong, should test virtual column + sync mv
+ for (NamedExpression virtualColumn : virtualColumns) {
+ slots.add(virtualColumn.toSlot());
+ }
+ return slots;
+ }
+
+ /**
+ * withPreAggStatus
+ */
+ @Override
+ public LogicalOlapTableStreamScan withPreAggStatus(PreAggStatus preAggStatus) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ Optional.empty(), Optional.of(getLogicalProperties()),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, cachedOutput, tableSample, directMvScan,
+ colToSubPathsMap, manuallySpecifiedTabletIds, operativeSlots, virtualColumns,
+ scoreOrderKeys, scoreLimit, scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ @Override
+ public LogicalOlapTableStreamScan withGroupExpression(Optional<GroupExpression> groupExpression) {
+ return AbstractPlan.copyWithSameId(this, () ->
+ new LogicalOlapTableStreamScan(relationId, (Table) table, qualifier,
+ groupExpression, Optional.of(getLogicalProperties()),
+ selectedPartitionIds, partitionPruned, selectedTabletIds,
+ selectedIndexId, indexSelected, preAggStatus, manuallySpecifiedPartitions,
+ hints, cacheSlotWithSlotName, cachedOutput, tableSample, directMvScan,
+ colToSubPathsMap, manuallySpecifiedTabletIds, operativeSlots, virtualColumns,
+ scoreOrderKeys, scoreLimit, scoreRangeInfo, annOrderKeys, annLimit, tableAlias));
+ }
+
+ public void setIsIncrementalScan(boolean isIncrementalScan) {
+ this.isIncrementalScan = isIncrementalScan;
+ }
+
+ public boolean isIncrementalScan() {
+ return isIncrementalScan;
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (!super.equals(o)) {
+ return false;
+ }
+ if (this == o) {
+ return true;
+ }
+ LogicalOlapTableStreamScan that = (LogicalOlapTableStreamScan) o;
+ return that.cachedOutput.equals(cachedOutput);
Review Comment:
why check cachedOutput ? should check isIcrementalScan ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org