[GitHub] [hudi] KnightChess commented on a diff in pull request #8794: [HUDI-6257] fix upgrade table version check partition path with hive …

["KnightChess (via GitHub)" <gi...@apache.org>]

KnightChess commented on code in PR #8794:
URL: https://github.com/apache/hudi/pull/8794#discussion_r1205012639


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/upgrade/FourToFiveUpgradeHandler.java:
##########
@@ -71,4 +83,26 @@ public Map<ConfigProperty, String> upgrade(HoodieWriteConfig config, HoodieEngin
     }
     return new HashMap<>();
   }
+
+  private String generatorPartitionPath(HoodieWriteConfig config, HoodieTableMetaClient metaClient) {
+    HoodieTableConfig tableConfig = metaClient.getTableConfig();
+    String partitionPath = DEPRECATED_DEFAULT_PARTITION_PATH;
+    try {
+      if (tableConfig.getPartitionFields().isPresent()) {

Review Comment:
   ok, I will update it. And I found one scene that was hard to fix, 
   ```shell
   0.dt=20210101/hour=01
   1.dt=20210101/hour=default
   2.dt=default/hour=default
   3.dt=20210102/hour=default
   ```
   It is difficult to identify the default partition in row 1 and row 3
   may be I can only check partitionPath: dt=default and  dt=default/ht=default



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org