[GitHub] tysonnorris commented on a change in pull request #4229: Add support for TTL at collection level with CosmosDB

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #4229: Add support for TTL at collection level with CosmosDB
URL: https://github.com/apache/incubator-openwhisk/pull/4229#discussion_r250787685
 
 

 ##########
 File path: common/scala/src/main/resources/application.conf
 ##########
 @@ -169,6 +169,9 @@ whisk {
         # Select from one of the supported
         # https://azure.github.io/azure-cosmosdb-java/1.0.0/com/microsoft/azure/cosmosdb/ConsistencyLevel.html
         consistency-level = "Session"
+
+        # TTL duration. By default no TTL is set unless explicitly configured
+    #   time-to-live      = 60 s
 
 Review comment:
   It may not be obvious that this example (60s) means documents will only reside in any of these collections for 60s. 
   I would 
   * emphasize this a bit more (e.g. ENABLING THIS VALUE  MEANS YOUR DATA WILL NOT BE PERMANENTLY STORED)
   * disable this for WhiskAuth + WhiskEntity (is there any good use case for these?)
   * or maybe only include any sample config only for WhiskActivation collection (this would be a more typical real config right?) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services