You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/12/15 10:11:24 UTC
[GitHub] [lucene-solr] iverase opened a new pull request #2147: LUCENE-9637: Clean up ShapeField/ShapeQuery random test
iverase opened a new pull request #2147:
URL: https://github.com/apache/lucene-solr/pull/2147
Removes some unused code and replaces the Point implementation on the test with the Point implementation in the geo package.
cc: @nknize
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] jbampton commented on a change in pull request #2147: LUCENE-9637: Clean up ShapeField/ShapeQuery random test
Posted by GitBox <gi...@apache.org>.
jbampton commented on a change in pull request #2147:
URL: https://github.com/apache/lucene-solr/pull/2147#discussion_r543223927
##########
File path: lucene/core/src/test/org/apache/lucene/document/BaseXYShapeTestCase.java
##########
@@ -126,24 +132,12 @@ protected boolean rectCrossesDateline(Object rect) {
return false;
}
- /** use {@link ShapeTestUtil#nextPolygon()} to create a random line; TODO: move to GeoTestUtil */
+ /** use {@link ShapeTestUtil#nextPolygon()} to create a random line */
@Override
public XYLine nextLine() {
- return getNextLine();
- }
-
- public static XYLine getNextLine() {
- XYPolygon poly = ShapeTestUtil.nextPolygon();
- float[] x = new float[poly.numPoints() - 1];
- float[] y = new float[x.length];
- for (int i = 0; i < x.length; ++i) {
- x[i] = poly.getPolyX(i);
- y[i] = poly.getPolyY(i);
- }
-
- return new XYLine(x, y);
+ return ShapeTestUtil.nextLine();
}
-
+
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] iverase merged pull request #2147: LUCENE-9637: Clean up ShapeField/ShapeQuery random test
Posted by GitBox <gi...@apache.org>.
iverase merged pull request #2147:
URL: https://github.com/apache/lucene-solr/pull/2147
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org