[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #377: Add support for conditional submodules updates

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #377: Add support for conditional submodules updates
URL: https://github.com/apache/mynewt-newt/pull/377#discussion_r381421124
 
 

 ##########
 File path: newt/repo/repo.go
 ##########
 @@ -191,6 +194,22 @@ func (r *Repo) patchesFilePath() string {
 		"/.patches/"
 }
 
+// Check that there is a list of submodules to clone; if the key is
+// not present, assume that all submodules should be cloned, otherwise
+// only those configured will be cloned (or none if "")
+func (r *Repo) loadSubmoduleConfig(yc *ycfg.YCfg) error {
 
 Review comment:
   Other functions that take a `ycfg.YCfg` object take it by value, not reference.  It might make sense to change this function to match the others.
   
   After programming in Go for several years, I still have no idea when to use pointers and when not to, so I am *not* saying pass-by-value is "better" here, just more consistent :).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services