You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/08 15:40:00 UTC
[jira] [Commented] (LUCENE-8086) G3d wrapper: Improve circles for
non spherical planets
[ https://issues.apache.org/jira/browse/LUCENE-8086?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16283735#comment-16283735 ]
ASF GitHub Bot commented on LUCENE-8086:
----------------------------------------
GitHub user iverase opened a pull request:
https://github.com/apache/lucene-solr/pull/288
LUCENE-8086
Here are the changes, in particular:
- Geo3dFactory: Use GeoExactCircle for non-spherical planets.
- Geo3dCircleShape: Remove method relate.
- Geo3DShape: Use new factory method for building GeoBbox from bounds object.
- Geo3dDistanceCalculator: use pointonbearing from planet model.
- Test refactoring
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iverase/lucene-solr master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/288.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #288
----
commit 73d9ce324b217c633ae72b24233099dd2afc43d5
Author: iverase <iv...@eso.org>
Date: 2017-12-08T15:33:22Z
LUCENE-8086
----
> G3d wrapper: Improve circles for non spherical planets
> ------------------------------------------------------
>
> Key: LUCENE-8086
> URL: https://issues.apache.org/jira/browse/LUCENE-8086
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
>
> Hi [~dsmiley],
> The purpose of this ticket is to add a new circle shape (GeoExactCircle) for non-spherical planets and therefore remove the method relate from Geo3dCircleShape. The patch will include some simplifications on the wrapper and some refactoring of the tests.
> I will open shortly a pull request.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org