[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4375: Fix errors when alter materialized view which based on dup table

[GitBox <gi...@apache.org>]

wutiangan commented on a change in pull request #4375:
URL: https://github.com/apache/incubator-doris/pull/4375#discussion_r471537748



##########
File path: fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java
##########
@@ -556,6 +556,10 @@ private void addColumnInternal(OlapTable olapTable, Column newColumn, ColumnPosi
                 throw new DdlException("Can not assign aggregation method on column in Duplicate data model table: " + newColName);
             }
             if (!newColumn.isKey()) {

Review comment:
       why not put "from lint 559 to line 562" outside of if stmt?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org