You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Daniel Oliveira (Jira)" <ji...@apache.org> on 2020/08/12 22:56:00 UTC

[jira] [Commented] (BEAM-10676) Timers use the input timestamp as the timer output timestamp which prevents watermark progress

    [ https://issues.apache.org/jira/browse/BEAM-10676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176642#comment-17176642 ] 

Daniel Oliveira commented on BEAM-10676:
----------------------------------------

Is this just waiting for the PR in question to be merged in?

> Timers use the input timestamp as the timer output timestamp which prevents watermark progress
> ----------------------------------------------------------------------------------------------
>
>                 Key: BEAM-10676
>                 URL: https://issues.apache.org/jira/browse/BEAM-10676
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core, sdk-py-harness
>            Reporter: Maximilian Michels
>            Assignee: Maximilian Michels
>            Priority: P2
>             Fix For: 2.24.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> By default, the Python SDK adds a timer output timestamp equal to the current timestamp of an element. This is problematic because
> 1. We hold back the output watermark on the current element's timestamp for every timer
> 2. It doesn't match the behavior in the Java SDK which defaults to using the fire timestamp as the timer output timestamp (and adds a hold on it)
> 3. There is no way for the user to influence this behavior because there is no user-facing API 
> https://github.com/apache/beam/blob/dfadde2d3ee0a0487362dbcca80388fdc2ef2302/sdks/python/apache_beam/runners/worker/bundle_processor.py#L650
> We should use the fire timestamp as the default output timestamp.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)