[GitHub] jukka commented on a change in pull request #1717: Update license banners in net/ and pagespeed/

[GitBox <gi...@apache.org>]

jukka commented on a change in pull request #1717: Update license banners in net/ and pagespeed/
URL: https://github.com/apache/incubator-pagespeed-mod/pull/1717#discussion_r162151651
 
 

 ##########
 File path: net/instaweb/js/data_to_c.cc
 ##########
 @@ -17,21 +33,6 @@ DEFINE_string(c_file, "/tmp/a.c", "Output C file");
 DEFINE_string(varname, "str", "Variable name.");
 
 const char kOutputTemplate[] =
 
 Review comment:
   I wonder if we should put the ASF licence header also here. Usually code generated by Apache projects also falls under the same licensing conditions and we'd include a copy of the license header also in such files. But I'm not familiar enough with this case to know whether including the header here makes sense. Based on the fact that a header was included before, I'd opt for replacing it with the ASF header instead of removing the header entirely.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services