[GitHub] [spark] JoshRosen commented on pull request #35065: [SPARK-37785][SQL][CORE] Add Utils.isAtExecutorSide

[GitBox <gi...@apache.org>]

JoshRosen commented on pull request #35065:
URL: https://github.com/apache/spark/pull/35065#issuecomment-1002916194


   Just brainstorming aloud here:
   
   Is the name `isAtExecutorSide` potentially confusing in the context of `local` mode (since in that case we don't have separate executor processes)?
   
   I suppose it makes sense if we think of "at the executor side" as meaning
   
   >  "in the context of a running Spark task" 
   
    instead of meaning
   
   > "not in the driver JVM".
   
   
   If we wanted to be more precise, maybe we could call this `Utils.inRunningSparkTask` or something like that.
   
   I don't feel super strongly about this. I mostly just want to flag the potential for ambiguity in case a new developer uses this method expecting the "not in the driver JVM" semantic. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org