[GitHub] akshayrai commented on a change in pull request #3866: [TE] detection - task scheduler backoff fix

[GitBox <gi...@apache.org>]

akshayrai commented on a change in pull request #3866: [TE] detection - task scheduler backoff fix
URL: https://github.com/apache/incubator-pinot/pull/3866#discussion_r259512209
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertJob.java
 ##########
 @@ -61,6 +63,21 @@ public void execute(JobExecutionContext jobExecutionContext) throws JobExecution
 
     DetectionAlertTaskInfo taskInfo = new DetectionAlertTaskInfo(detectionAlertConfigId);
 
+    // check if a task for this detection alerter is already scheduled
+    String jobName = String.format("%s_%d", TaskConstants.TaskType.DETECTION_ALERT, detectionAlertConfigId);
+    List<TaskDTO> scheduledTasks = taskDAO.findByPredicate(Predicate.AND(
 
 Review comment:
   Do we know why the tasks are piling up? Is it because of one server?
   
   Adding this condition might stop the tasks from piling up but we could delay the detection and increase the MTTD without even realizing it, right!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org