You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/13 00:19:56 UTC
[GitHub] [openwhisk] codecov-io commented on issue #4860: fix creation logic
broken from wait changes
codecov-io commented on issue #4860: fix creation logic broken from wait changes
URL: https://github.com/apache/openwhisk/pull/4860#issuecomment-598488141
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=h1) Report
> Merging [#4860](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/394e9f6cb3ec09dd4a5ce158afaf2268d64fec12&el=desc) will **decrease** coverage by `46.35%`.
> The diff coverage is `18.42%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4860 +/- ##
===========================================
- Coverage 82.37% 36.02% -46.36%
===========================================
Files 198 200 +2
Lines 9021 9294 +273
Branches 353 372 +19
===========================================
- Hits 7431 3348 -4083
- Misses 1590 5946 +4356
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJVdGlsLnNjYWxh) | `0.00% <0.00%> (-96.78%)` | :arrow_down: |
| [...e/elasticsearch/ElasticSearchActivationStore.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvZWxhc3RpY3NlYXJjaC9FbGFzdGljU2VhcmNoQWN0aXZhdGlvblN0b3JlLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...re/containerpool/kubernetes/KubernetesClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDbGllbnQuc2NhbGE=) | `0.00% <0.00%> (-21.06%)` | :arrow_down: |
| [...erpool/kubernetes/KubernetesContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL0t1YmVybmV0ZXNDb250YWluZXJGYWN0b3J5LnNjYWxh) | `0.00% <ø> (ø)` | |
| [...ore/containerpool/kubernetes/WhiskPodBuilder.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9rdWJlcm5ldGVzL1doaXNrUG9kQnVpbGRlci5zY2FsYQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...he/openwhisk/core/entity/ParameterEncryption.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlckVuY3J5cHRpb24uc2NhbGE=) | `29.31% <29.31%> (ø)` | |
| [...a/org/apache/openwhisk/core/entity/Parameter.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1BhcmFtZXRlci5zY2FsYQ==) | `63.26% <50.00%> (-27.31%)` | :arrow_down: |
| [.../scala/org/apache/openwhisk/core/WhiskConfig.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvV2hpc2tDb25maWcuc2NhbGE=) | `94.89% <100.00%> (+0.07%)` | :arrow_up: |
| [...org/apache/openwhisk/core/entity/WhiskAction.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrQWN0aW9uLnNjYWxh) | `80.32% <100.00%> (-10.93%)` | :arrow_down: |
| [...rg/apache/openwhisk/core/entity/WhiskPackage.scala](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L1doaXNrUGFja2FnZS5zY2FsYQ==) | `58.33% <100.00%> (-38.28%)` | :arrow_down: |
| ... and [140 more](https://codecov.io/gh/apache/openwhisk/pull/4860/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=footer). Last update [995387f...985553a](https://codecov.io/gh/apache/openwhisk/pull/4860?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services