You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Ajay Yadava <aj...@gmail.com> on 2015/12/16 13:25:51 UTC
Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the
Triage API
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review110652
-----------------------------------------------------------
falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java (line 324)
<https://reviews.apache.org/r/40779/#comment170684>
This function doesn't seem to be used anywhere.
What does this function do? It seems it just changes the first output feed to new feed in datasets.
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java (line 58)
<https://reviews.apache.org/r/40779/#comment170685>
cluster10C , server0C? Any particular reason for this kind of naming convention?
falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java (lines 96 - 110)
<https://reviews.apache.org/r/40779/#comment170686>
This code seems to be common across tests. Is it possible to extract it out? I am thinking it will reduce the code to core assertions and improve readability. It's ok if it is not possible to extract it out easily or it becomes too clunky.
- Ajay Yadava
On Nov. 27, 2015, 6:26 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2015, 6:26 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo instance triage tests wil be added in a separate class as part of a separate patch.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java 67d9ee2
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 921a303
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 00ef79d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40779/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>
Re: Review Request 40779: [Falcon-1377] Add tests in falcon for the
Triage API
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 16, 2015, 12:25 p.m., Ajay Yadava wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java, line 58
> > <https://reviews.apache.org/r/40779/diff/1/?file=1148011#file1148011line58>
> >
> > cluster10C , server0C? Any particular reason for this kind of naming convention?
>
> Karishma Gulati wrote:
> cluster1OC stands for cluster's Oozie Client. Changing it to clusterOC. This naming convention is consistent throughout the suite.
Aah, the font confused me whether it was Zero or O. :)
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40779/#review110652
-----------------------------------------------------------
On Dec. 17, 2015, 2:50 p.m., Karishma Gulati wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40779/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 2:50 p.m.)
>
>
> Review request for Falcon.
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Add tests for the feature explained in https://issues.apache.org/jira/browse/FALCON-796 - Enable users to triage data processing issues through falcon.
> As part of this patch, will add tests corresponding to single colo processing. Cross-colo instance triage tests wil be added in a separate class as part of a separate patch.
>
>
> Diffs
> -----
>
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/ResponseErrors.java 921a303
> falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/InstanceUtil.java 3d05ae9
> falcon-regression/merlin/src/main/java/org/apache/falcon/regression/testHelper/BaseTestClass.java 00ef79d
> falcon-regression/merlin/src/test/java/org/apache/falcon/regression/triage/TriageAPISingleColoTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/40779/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Karishma Gulati
>
>