You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/19 13:45:14 UTC
[GitHub] [incubator-eventmesh] sudharsan-gitrepo opened a new pull request, #1662: [Issue #1558] Replacing default encoding with UTF-8 in ConfigurationWrapper
sudharsan-gitrepo opened a new pull request, #1662:
URL: https://github.com/apache/incubator-eventmesh/pull/1662
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #1558
### Motivation
ConfigurationWrapper is using the default encoding while reading the data from a file in configPath, and this might cause application behaviour to vary between platforms, as described in https://github.com/apache/incubator-eventmesh/issues/1558
### Modifications
I have made changes to read the contents of the file in a fixed UTF-8 format, and this is possible by using the InputStreamReader.
### Documentation
- Does this pull request introduce a new feature? No, it's a fix to handle edge cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #1662: [ISSUE #1558] Replacing default encoding with UTF-8 in ConfigurationWrapper
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #1662:
URL: https://github.com/apache/incubator-eventmesh/pull/1662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org