You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2021/10/26 11:12:21 UTC

[GitHub] [libcloud] Kami commented on a change in pull request #1610: Vultr API v2

Kami commented on a change in pull request #1610:
URL: https://github.com/apache/libcloud/pull/1610#discussion_r736417096



##########
File path: libcloud/common/vultr.py
##########
@@ -136,3 +191,25 @@ def __str__(self):
 
     def __repr__(self):
         return "VultrException code %u '%s'" % (self.code, self.message)
+
+
+class VultrNetwork:
+    """
+    Represents information about a Vultr private network.
+    """
+
+    def __init__(self, id, cidr_block, location, extra=None):

Review comment:
       Since it's adding a bunch of new classes and methods, it wouldn't hurt to add type annotation :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org