Re: [PR] fix: drag a metric very quickly，the order is chaotic. [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #35867:
URL: https://github.com/apache/superset/pull/35867#issuecomment-4353663319

   @CoderSxy — checking in on this one. A few things are blocking it from progressing:
   
   - The branch is conflicting with master and CI is red; a rebase + green CI run is needed.
   - Reviewer bots flagged what look like real bugs that aren't addressed yet:
     - `AdhocFilterControl/index.jsx:301` — `this.values` is undefined here; it should use the destructured `values` and update via `setState` before calling `onChange` (per @copilot-pull-request-reviewer).
     - `DndFilterSelect.tsx:269` — the reorder path calls `setValues` but never `onChange(newValue)`, so the new order isn't propagated to the parent.
     - `DndColumnSelect.tsx:98` / `optionSelector.ts:95` — `reorder` is missing the bounds checks the sibling Dnd components have.
   - The PR description is still the unfilled template; a quick SUMMARY + TESTING INSTRUCTIONS would help reviewers.
   
   Let us know once those are addressed and we'll take another look. If you've moved on, no worries — just give us a heads-up so we can close it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org