You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Greg Mann <gr...@mesosphere.io> on 2018/08/14 16:41:40 UTC
Review Request 68345: Fixed an expectation in the master tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
Bugs: MESOS-9154
https://issues.apache.org/jira/browse/MESOS-9154
Repository: mesos
Description
-------
In `MasterTest.TaskStateMetrics`, since the clock is resumed at the
end of the test, it's possible that the allocation interval may elapse
on a heavily-loaded machine and the scheduler may receive additional
offers.
This patch updates an expectation to accommodate additional offers
sent to the scheduler.
Diffs
-----
src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
Diff: https://reviews.apache.org/r/68345/diff/1/
Testing
-------
Thanks,
Greg Mann
Re: Review Request 68345: Fixed an expectation in the master tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/#review207239
-----------------------------------------------------------
PASS: Mesos patch 68345 was successfully built and tested.
Reviews applied: `['68345']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2148/mesos-review-68345
- Mesos Reviewbot Windows
On Aug. 14, 2018, 9:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68345/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 9:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
>
>
> Bugs: MESOS-9154
> https://issues.apache.org/jira/browse/MESOS-9154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In `MasterTest.TaskStateMetrics`, since the clock is resumed at the
> end of the test, it's possible that the allocation interval may elapse
> on a heavily-loaded machine and the scheduler may receive additional
> offers.
>
> This patch updates an expectation to accommodate additional offers
> sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
>
>
> Diff: https://reviews.apache.org/r/68345/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68345: Fixed an expectation in the master tests.
Posted by Gastón Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/#review207237
-----------------------------------------------------------
Ship it!
Ship It!
- Gastón Kleiman
On Aug. 14, 2018, 9:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68345/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 9:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
>
>
> Bugs: MESOS-9154
> https://issues.apache.org/jira/browse/MESOS-9154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In `MasterTest.TaskStateMetrics`, since the clock is resumed at the
> end of the test, it's possible that the allocation interval may elapse
> on a heavily-loaded machine and the scheduler may receive additional
> offers.
>
> This patch updates an expectation to accommodate additional offers
> sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
>
>
> Diff: https://reviews.apache.org/r/68345/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68345: Fixed an expectation in the master tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/#review207267
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68345]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 14, 2018, 9:41 a.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68345/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 9:41 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
>
>
> Bugs: MESOS-9154
> https://issues.apache.org/jira/browse/MESOS-9154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In `MasterTest.TaskStateMetrics`, since the clock is resumed at the
> end of the test, it's possible that the allocation interval may elapse
> on a heavily-loaded machine and the scheduler may receive additional
> offers.
>
> This patch updates an expectation to accommodate additional offers
> sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
>
>
> Diff: https://reviews.apache.org/r/68345/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>
Re: Review Request 68345: Fixed an expectation in the master tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68345/#review207609
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 14, 2018, 4:41 p.m., Greg Mann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68345/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2018, 4:41 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
>
>
> Bugs: MESOS-9154
> https://issues.apache.org/jira/browse/MESOS-9154
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In `MasterTest.TaskStateMetrics`, since the clock is resumed at the
> end of the test, it's possible that the allocation interval may elapse
> on a heavily-loaded machine and the scheduler may receive additional
> offers.
>
> This patch updates an expectation to accommodate additional offers
> sent to the scheduler.
>
>
> Diffs
> -----
>
> src/tests/master_tests.cpp 5accfbb8681ab2d903cca13b0ef05a3bdce9b1fe
>
>
> Diff: https://reviews.apache.org/r/68345/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Greg Mann
>
>