You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/07 22:42:56 UTC
[GitHub] [couchdb] jjrodrig opened a new pull request #2641: Port
design_docs.js tests from js into elixir
jjrodrig opened a new pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
This PR ports the design_docs.js test suite into the elixir test suite
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
```
make elixir tests=test/elixir/test/design_docs_test.exs
```
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
N/A
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [X] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] dottorblaster commented on a change in pull request
#2641: Port design_docs.js tests from js into elixir
Posted by GitBox <gi...@apache.org>.
dottorblaster commented on a change in pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641#discussion_r393042322
##########
File path: test/javascript/tests/design_docs.js
##########
@@ -10,7 +10,9 @@
// License for the specific language governing permissions and limitations under
// the License.
+couchTests.elixir = true;
Review comment:
Is this something new?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] dottorblaster commented on a change in pull request
#2641: Port design_docs.js tests from js into elixir
Posted by GitBox <gi...@apache.org>.
dottorblaster commented on a change in pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641#discussion_r393115856
##########
File path: test/javascript/tests/design_docs.js
##########
@@ -10,7 +10,9 @@
// License for the specific language governing permissions and limitations under
// the License.
+couchTests.elixir = true;
Review comment:
Oh! So we'll have to upgrade some :) the rest is perfect, just merge 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jjrodrig commented on a change in pull request #2641:
Port design_docs.js tests from js into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on a change in pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641#discussion_r393143337
##########
File path: test/javascript/tests/design_docs.js
##########
@@ -10,7 +10,9 @@
// License for the specific language governing permissions and limitations under
// the License.
+couchTests.elixir = true;
Review comment:
Yes I think we should check the ported tests and tag it correctly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jjrodrig merged pull request #2641: Port design_docs.js
tests from js into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig merged pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jjrodrig commented on a change in pull request #2641:
Port design_docs.js tests from js into elixir
Posted by GitBox <gi...@apache.org>.
jjrodrig commented on a change in pull request #2641: Port design_docs.js tests from js into elixir
URL: https://github.com/apache/couchdb/pull/2641#discussion_r393114131
##########
File path: test/javascript/tests/design_docs.js
##########
@@ -10,7 +10,9 @@
// License for the specific language governing permissions and limitations under
// the License.
+couchTests.elixir = true;
Review comment:
I just noticed that this is the correct way to tag the porting progress. I took a wrong reference for this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services