You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/28 06:11:40 UTC

[GitHub] [flink] reswqa commented on a diff in pull request #20904: [FLINK-29425] Hybrid full spilling strategy triggering spilling frequently

reswqa commented on code in PR #20904:
URL: https://github.com/apache/flink/pull/20904#discussion_r981982729


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataManager.java:
##########
@@ -99,6 +115,20 @@ public HsMemoryDataManager(
                             bufferCompressor,
                             this);
         }
+        this.previousPoolSize = getPoolSize();
+        if (poolSizeCheckInterval > 0) {
+            poolSizeChecker.scheduleAtFixedRate(
+                    () -> {
+                        int currentPoolSize = getPoolSize();
+                        if (previousPoolSize > currentPoolSize) {
+                            callWithLock(() -> spillStrategy.decideActionWithGlobalInfo(this));
+                        }
+                        previousPoolSize = currentPoolSize;

Review Comment:
   good catch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org