[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10473: feat: refactor error components and add database issue code

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #10473:
URL: https://github.com/apache/incubator-superset/pull/10473#discussion_r464557230



##########
File path: superset/db_engine_specs/druid.py
##########
@@ -35,6 +35,7 @@ class DruidEngineSpec(BaseEngineSpec):  # pylint: disable=abstract-method
     """Engine spec for Druid.io"""
 
     engine = "druid"
+    engine_name = "Druid"

Review comment:
       ```suggestion
       engine_name = "Apache Druid"
   ```

##########
File path: superset/db_engine_specs/base.py
##########
@@ -137,6 +137,7 @@ class BaseEngineSpec:  # pylint: disable=too-many-public-methods
     """Abstract class for database engine specific configurations"""
 
     engine = "base"  # str as defined in sqlalchemy.engine.engine
+    engine_name = "Base Database"

Review comment:
       Can this be an optional `str`? No one should be instantiating the base class.

##########
File path: superset/db_engine_specs/pinot.py
##########
@@ -24,6 +24,7 @@
 
 class PinotEngineSpec(BaseEngineSpec):  # pylint: disable=abstract-method
     engine = "pinot"
+    engine_name = "Pinot"

Review comment:
       ```suggestion
       engine_name = "Apache Pinot"
   ```

##########
File path: superset/db_engine_specs/kylin.py
##########
@@ -25,6 +25,7 @@ class KylinEngineSpec(BaseEngineSpec):  # pylint: disable=abstract-method
     """Dialect for Apache Kylin"""
 
     engine = "kylin"
+    engine_name = "Kylin"

Review comment:
       ```suggestion
       engine_name = "Apache Kylin"
   ```

##########
File path: superset/db_engine_specs/hive.py
##########
@@ -55,6 +55,7 @@ class HiveEngineSpec(PrestoEngineSpec):
     """Reuses PrestoEngineSpec functionality."""
 
     engine = "hive"
+    engine_name = "Hive"

Review comment:
       ```suggestion
       engine_name = "Apache Hive"
   ```

##########
File path: superset/db_engine_specs/impala.py
##########
@@ -27,6 +27,7 @@ class ImpalaEngineSpec(BaseEngineSpec):
     """Engine spec for Cloudera's Impala"""
 
     engine = "impala"
+    engine_name = "Impala"

Review comment:
       ```suggestion
       engine_name = "Apache Impala"
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org