[GitHub] [hudi] nsivabalan commented on a change in pull request #3976: [HUDI-2744] Fixing parsing of metadadata table compaction timestamp

[GitBox <gi...@apache.org>]

nsivabalan commented on a change in pull request #3976:
URL: https://github.com/apache/hudi/pull/3976#discussion_r747747218



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstantTimeGenerator.java
##########
@@ -65,6 +71,12 @@ public static Date parseInstantTime(String timestamp) {
       if (timestamp.equals(ALL_ZERO_TIMESTAMP)) {
         return new Date(0);
       }
+      // compaction and cleaning in metadata has special format. handling it here.
+      if (timestamp.length() == MILLIS_INSTANT_ID_LENGTH) {

Review comment:
       yes, I will rework this again once with the other patch. plan is to land this one and then rework with ms granularity patch. other patch has lot of conflicts to be fixed anyways. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org