You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/09 09:17:06 UTC
[GitHub] [incubator-nuttx] anjiahao1 opened a new pull request, #7565: pthread_barrier:don't destory when barrier used
anjiahao1 opened a new pull request, #7565:
URL: https://github.com/apache/incubator-nuttx/pull/7565
this is fix a ltp test case and update
the error code of pthread_barrierdestroy
ltptcase is : apps/testing/ltp/ltp/testcases/open_posix_testsuite/conformance/interfaces/pthread_barrier_destroy/2-1.c
Signed-off-by: anjiahao <an...@xiaomi.com>
## Summary
Enhance pthread_barrier api
## Impact
pthread_barrier
## Testing
ltp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7565: pthread_barrier:don't destory when barrier used
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7565:
URL: https://github.com/apache/incubator-nuttx/pull/7565#issuecomment-1308729448
Please fix title typo: destory -> destroy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7565: pthread_barrier:don't destroy when barrier used
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7565:
URL: https://github.com/apache/incubator-nuttx/pull/7565
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] yamt commented on a diff in pull request #7565: pthread_barrier:don't destory when barrier used
Posted by GitBox <gi...@apache.org>.
yamt commented on code in PR #7565:
URL: https://github.com/apache/incubator-nuttx/pull/7565#discussion_r1017677013
##########
include/pthread.h:
##########
@@ -357,6 +357,7 @@ struct pthread_barrier_s
{
sem_t sem;
unsigned int count;
+ bool busy;
Review Comment:
isn't it enough to look at semcount/waitlist?
##########
libs/libc/pthread/pthread_barrierwait.c:
##########
@@ -143,6 +145,7 @@ int pthread_barrier_wait(FAR pthread_barrier_t *barrier)
* zero.
*/
+ barrier->busy = false;
Review Comment:
don't you want to wait for all the threads?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org