You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/06/14 21:28:56 UTC

Review Request 35443: Configs: not enough physical memory warning - not actionable, persistent, and annoying

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35443/
-----------------------------------------------------------

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-11918
    https://issues.apache.org/jira/browse/AMBARI-11918


Repository: ambari


Description
-------

Every time I tried to save a config, there's a warning that pops up saying not enough physical RAM on every host. It's persistent and annoying. Furthermore, this doesn't tell me what's taking up how much memory, so it's not very actionable.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 1c099fd 
  ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py dc64770 

Diff: https://reviews.apache.org/r/35443/diff/


Testing
-------

----------------------------------------------------------------------
Ran 266 tests in 8.881s

OK
----------------------------------------------------------------------
Total run:790
Total errors:0
Total failures:0
OK


Thanks,

Dmytro Sen


Re: Review Request 35443: Configs: not enough physical memory warning - not actionable, persistent, and annoying

Posted by Artem Baranchuk <ab...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35443/#review88057
-----------------------------------------------------------

Ship it!


Ship It!

- Artem Baranchuk


On Июнь 14, 2015, 7:28 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35443/
> -----------------------------------------------------------
> 
> (Updated Июнь 14, 2015, 7:28 п.п.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11918
>     https://issues.apache.org/jira/browse/AMBARI-11918
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Every time I tried to save a config, there's a warning that pops up saying not enough physical RAM on every host. It's persistent and annoying. Furthermore, this doesn't tell me what's taking up how much memory, so it's not very actionable.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 1c099fd 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py dc64770 
> 
> Diff: https://reviews.apache.org/r/35443/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 8.881s
> 
> OK
> ----------------------------------------------------------------------
> Total run:790
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 35443: Configs: not enough physical memory warning - not actionable, persistent, and annoying

Posted by Dmytro Sen <ds...@hortonworks.com>.

> On Июнь 14, 2015, 7:38 п.п., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py, line 350
> > <https://reviews.apache.org/r/35443/diff/1/?file=984532#file984532line350>
> >
> >     We should add more information instead of removing the warning.

I think we'll remove for Ambari-2.1, and review it again in 2.2


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35443/#review87879
-----------------------------------------------------------


On Июнь 14, 2015, 7:28 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35443/
> -----------------------------------------------------------
> 
> (Updated Июнь 14, 2015, 7:28 п.п.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11918
>     https://issues.apache.org/jira/browse/AMBARI-11918
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Every time I tried to save a config, there's a warning that pops up saying not enough physical RAM on every host. It's persistent and annoying. Furthermore, this doesn't tell me what's taking up how much memory, so it's not very actionable.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 1c099fd 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py dc64770 
> 
> Diff: https://reviews.apache.org/r/35443/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 8.881s
> 
> OK
> ----------------------------------------------------------------------
> Total run:790
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 35443: Configs: not enough physical memory warning - not actionable, persistent, and annoying

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35443/#review87879
-----------------------------------------------------------



ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
<https://reviews.apache.org/r/35443/#comment140292>

    We should add more information instead of removing the warning.


- Sid Wagle


On June 14, 2015, 7:28 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35443/
> -----------------------------------------------------------
> 
> (Updated June 14, 2015, 7:28 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-11918
>     https://issues.apache.org/jira/browse/AMBARI-11918
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Every time I tried to save a config, there's a warning that pops up saying not enough physical RAM on every host. It's persistent and annoying. Furthermore, this doesn't tell me what's taking up how much memory, so it's not very actionable.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 1c099fd 
>   ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py dc64770 
> 
> Diff: https://reviews.apache.org/r/35443/diff/
> 
> 
> Testing
> -------
> 
> ----------------------------------------------------------------------
> Ran 266 tests in 8.881s
> 
> OK
> ----------------------------------------------------------------------
> Total run:790
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>