[GitHub] [superset] kgabryje commented on a diff in pull request #20890: feat: Use SPA navigation from datasets list to Explore

[GitBox <gi...@apache.org>]

kgabryje commented on code in PR #20890:
URL: https://github.com/apache/superset/pull/20890#discussion_r934614017


##########
superset-frontend/src/components/GenericLink/GenericLink.tsx:
##########
@@ -29,9 +30,9 @@ export const GenericLink = <S,>({
   ...rest
 }: React.PropsWithoutRef<LinkProps<S>> &
   React.RefAttributes<HTMLAnchorElement>) => {
-  if (typeof to === 'string' && /^https?:\/\//.test(to)) {
+  if (typeof to === 'string' && isUrlExternal(to)) {
     return (
-      <a data-test="external-link" href={to} {...rest}>
+      <a data-test="external-link" href={parseUrl(to)} {...rest}>

Review Comment:
   Good point! I'll do that in a separate PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org