You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:10:29 UTC
[GitHub] [superset] junlincc opened a new issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
junlincc opened a new issue #15070:
URL: https://github.com/apache/superset/issues/15070
In the first video below, I created a big number chart with a "name filter" from Explore. I saved it to a new dashboard(with 7 random name filters value).
**Problem 1:** there's no way to tell whether a chart on the dashboard already carries any filters or not from the indicator. but yes user can read query from dashboard, but it's time consuming to look at one by one. Should we add a new section in the indicator to show original chart filters? @rusackas
**Problem 2:** when I create the same "name" filter from Dashboard, I see 250 options available, no value is selected in the drop down. then I select "Aaron" as additional filter value(AND WHERE name in Aaron) and click Apply. No data shows. My expected behavior is that the original big number 426K should change(increase) after the number of filter value increases from 7 to 8.
but still, there's no way to tell the charts is being filtered twice unless user click View query from dashboard "..." @villebro @michael-s-molina @kgabryje
https://user-images.githubusercontent.com/67837651/121432478-937caf00-c92f-11eb-8823-5ef8f04176e7.mov
**Problem 3:** When I click View chart from Explore, both filters(8 total) appear in the Filter section, which is expected.
What's missing is the yellow warning sign to indicate the second "name in" is carried from the dashboard @kgabryje
**Problem 4:** Chart is not showing properly in Explore either with 2 separate filters. When i remove the second one and add the same value to the original filter(with 7 selected values), chart shows properly. @villebro
https://user-images.githubusercontent.com/67837651/121432534-a55e5200-c92f-11eb-9bc6-ae6dd96be6b8.mov
*problem 2 and 4 are top priorities among all native filter issues @villebro @kgabryje 🙏
*will convert each sub issue to a separate issue once we open a PR, and tag the new issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858298887
1 and 2: This is expected behavior (the same behavior applies to Filter Box). As Evan said, currently the filter indicator doesn't show filters specified in the chart (this is by design). If we want to change this it's a new feature, and one that will require a fair amount of design and usability research to make sure we don't clutter the dashboard indicators. I agree that having an "inherited filters" category could be a solution, but again, currently users don't expect to see the filter indicator at all if no native filters or filter boxes apply to a chart, making this a breaking change to the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858132367
> For #2, I'm not convinced this is a problem. If I go to explore and filter by the names Aaron, Bob, Dave, I see the accurate number on the dashboard. If I then add a native filter for Bob, I see the number drop. It's an intersection, essentially. If I select Steve in the native filters, the data is null... which is accurate.
it's not about number dropping, it's the chart has no data showing at allll.. @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858298887
I'll answer this one topic at a time:
1: This is expected behavior (the same behavior applies to Filter Box). As Evan said, currently the filter indicator doesn't show filters specified in the chart (this is by design). If we want to change this it's a new feature, and one that will require a fair amount of design and usability research to make sure we don't clutter the dashboard indicators. I agree that having an "inherited filters" category could be a solution, but again, currently users don't expect to see the filter indicator at all if no native filters or filter boxes apply to a chart, making this a breaking change to the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858129545
For #1, which is basically a usability issue, I can see one potential solution, though it needs some more thinking. We might be able to add a new category to the filter indicator, which would look kind of like this:
... but instead of "Applied Filters" it could display "Inherited Filters".
The catch is that we wouldn't want the filter indicator "pill" to be so darkly/obviously highlighted, since that would be confusing (i.e. the dashboard is not providing the filter... this is just additional context).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858298887
I'll answer this one topic at a time:
2: This is expected behavior (the same behavior applies to Filter Box). As Evan said, currently the filter indicator doesn't show filters specified in the chart (this is by design). If we want to change this it's a new feature, and one that will require a fair amount of design and usability research to make sure we don't clutter the dashboard indicators. I agree that having an "inherited filters" category could be a solution, but again, currently users don't expect to see the filter indicator at all if no native filters or filter boxes apply to a chart, making this a breaking change to the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858130394
For #2, I'm not convinced this is a problem. If I go to explore and filter by the names Aaron, Bob, Dave, I see the accurate number on the dashboard. If I then add a native filter for Bob, I see the number drop. It's an intersection, essentially. If I select Steve in the native filters, the data is null... which is accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858132367
> For #2, I'm not convinced this is a problem. If I go to explore and filter by the names Aaron, Bob, Dave, I see the accurate number on the dashboard. If I then add a native filter for Bob, I see the number drop. It's an intersection, essentially. If I select Steve in the native filters, the data is null... which is accurate.
it's not about number dropping, it's the chart has no data showing at allll when the filter is being overwriten.. @rusackas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858298887
I'll answer this one topic at a time:
1 and 2: This is expected behavior (the same behavior applies to Filter Box). As Evan said, currently the filter indicator doesn't show filters specified in the chart (this is by design). If we want to change this it's a new feature, and one that will require a fair amount of design and usability research to make sure we don't clutter the dashboard indicators. I agree that having an "inherited filters" category could be a solution, but again, currently users don't expect to see the filter indicator at all if no native filters or filter boxes apply to a chart, making this a breaking change to the current behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858301418
> 1 and 2: This is expected behavior (the same behavior applies to Filter Box). As Evan said, currently the filter indicator doesn't show filters specified in the chart (this is by design). If we want to change this it's a new feature, and one that will require a fair amount of design and usability research to make sure we don't clutter the dashboard indicators. I agree that having an "inherited filters" category could be a solution, but again, currently users don't expect to see the filter indicator at all if no native filters or filter boxes apply to a chart, making this a breaking change to the current behavior.
I understand 1 is current behavior but it's confusing, we can wait until we have more design resource. 2, overwriting filter breaks chart is very problematic. When stacked filters use different columns, we could treat them as `AND`, but it they use the same column, can we by-default use `OR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas edited a comment on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
rusackas edited a comment on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858390249
> > For #2, I'm not convinced this is a problem. If I go to explore and filter by the names Aaron, Bob, Dave, I see the accurate number on the dashboard. If I then add a native filter for Bob, I see the number drop. It's an intersection, essentially. If I select Steve in the native filters, the data is null... which is accurate.
>
> it's not about number dropping, it's the chart has no data showing at allll when the filter is being overwriten.. @rusackas
Let me explain/show what I'm seeing, but it seems that the native filter doesn't _overwrite_ the Explore filter, it effectively cascades.
For example, I set up a filter in Explore for the names Sophia, Dawn, and Cindy. 339K results.
In Explore, with no filter, the number is accurate:
<img width="1264" alt="Pasted_Image_6_10_21__1_34_AM" src="https://user-images.githubusercontent.com/812905/121484057-1af80b80-c98c-11eb-97dc-b3bc1c0db732.png">
If I select/filter on Sophia, who **is** _in the set_ of Sophia, Dawn, and Cindy, the number shrinks and looks accurate:
<img width="1232" alt="Pasted_Image_6_10_21__1_35_AM" src="https://user-images.githubusercontent.com/812905/121484228-3f53e800-c98c-11eb-98ec-d159a452f5e6.png">
If I select/filter on Adam, who **is not** _in the set of_ Sophia, Dawn, and Cindy, no data is found, which seems reasonable.
<img width="1233" alt="Pasted_Image_6_10_21__1_36_AM" src="https://user-images.githubusercontent.com/812905/121484514-87730a80-c98c-11eb-917f-a75ea372bbc0.png">
This seems reasonable to me, but perhaps I'm misconstruing the intended behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas closed issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
rusackas closed issue #15070:
URL: https://github.com/apache/superset/issues/15070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858299677
3. this appears to be a regression. Let's fix it asap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858133803
> it could display "Inherited Filters".
That will work, we should use unify the behavior in both Explore and Dashboard, having the same icon and label etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #15070:
URL: https://github.com/apache/superset/issues/15070#issuecomment-858390249
> > For #2, I'm not convinced this is a problem. If I go to explore and filter by the names Aaron, Bob, Dave, I see the accurate number on the dashboard. If I then add a native filter for Bob, I see the number drop. It's an intersection, essentially. If I select Steve in the native filters, the data is null... which is accurate.
>
> it's not about number dropping, it's the chart has no data showing at allll when the filter is being overwriten.. @rusackas
Let me explain/show what I'm seeing, but it seems that the native filter doesn't _overwrite_ the Explore filter, it effectively cascades.
For example, I set up a filter in Explore for the names Sophia, Dawn, and Cindy. 339K results.
In Explore, with no filter, the number is accurate:
<img width="1264" alt="Pasted_Image_6_10_21__1_34_AM" src="https://user-images.githubusercontent.com/812905/121484057-1af80b80-c98c-11eb-97dc-b3bc1c0db732.png">
If I select/filter on Sophia, who **is** _in the set_ of Sophia, Dawn, and Cindy, the number shrinks and looks accurate:
<img width="1232" alt="Pasted_Image_6_10_21__1_35_AM" src="https://user-images.githubusercontent.com/812905/121484228-3f53e800-c98c-11eb-98ec-d159a452f5e6.png">
If I select/filter on Adam, who **is not** _in the set of_ Sophia, Dawn, and Cindy, no data is found, which seems reasonable.
<img width="1233" alt="Pasted_Image_6_10_21__1_36_AM" src="https://user-images.githubusercontent.com/812905/121484514-87730a80-c98c-11eb-917f-a75ea372bbc0.png">
This seems reasonable to me, but perhaps I'm misconstruing the intended behavior?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro closed issue #15070: [native-filters*4]dashboard native filter overwriting charts filter(?) / incompatible
Posted by GitBox <gi...@apache.org>.
villebro closed issue #15070:
URL: https://github.com/apache/superset/issues/15070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org