You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/27 17:52:49 UTC

[GitHub] mistercrunch commented on issue #5485: Fix SQLA granularity conversion in migration c5756bec8b47

mistercrunch commented on issue #5485: Fix SQLA granularity conversion in migration c5756bec8b47
URL: https://github.com/apache/incubator-superset/pull/5485#issuecomment-408492627
 
 
   In theory db migrations should be immutable since some people may have checkpointed after the migration you are correcting. There may be a bit more flexibility on mutating migrations that have not yet been released to pypi, which I believe is the case here.
   
   It's probably easier to just create a new migration.
   
   Side note, I think we need to start tagging commits/PRs with migration as they cannot be cherry-picked and it's important to know that when doing release management.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org