You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "stdnt-xiao (via GitHub)" <gi...@apache.org> on 2023/05/09 06:28:03 UTC
[GitHub] [incubator-seatunnel] stdnt-xiao opened a new pull request, #4725: [Bugfix][Connector-V2][maxcompute] sink commit with Block not exsits on server
stdnt-xiao opened a new pull request, #4725:
URL: https://github.com/apache/incubator-seatunnel/pull/4725
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
close issuse[#4009](https://github.com/apache/incubator-seatunnel/pull/4009)
Currently,
I have only implemented single instance read and write Maxcompute TableTunnel,
and will further improve the implementation of multi instance read and write.
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
<img width="948" alt="image" src="https://user-images.githubusercontent.com/20313983/237011443-2cc4a37f-4730-4e8b-8c8b-12e6d6220bec.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #4725: [Bugfix][Connector-V2][maxcompute] sink commit with Block not exsits on server
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 commented on code in PR #4725:
URL: https://github.com/apache/incubator-seatunnel/pull/4725#discussion_r1188649304
##########
seatunnel-connectors-v2/connector-maxcompute/src/main/java/org/apache/seatunnel/connectors/seatunnel/maxcompute/sink/MaxcomputeWriter.java:
##########
@@ -42,9 +42,10 @@
@Slf4j
public class MaxcomputeWriter extends AbstractSinkWriter<SeaTunnelRow, Void> {
- private final RecordWriter recordWriter;
+ private RecordWriter recordWriter;
Review Comment:
no use
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] VincentSleepless commented on pull request #4725: [Bugfix][Connector-V2][maxcompute] sink commit with Block not exsits on server
Posted by "VincentSleepless (via GitHub)" <gi...@apache.org>.
VincentSleepless commented on PR #4725:
URL: https://github.com/apache/incubator-seatunnel/pull/4725#issuecomment-1542146257
i have anthor question .
how many data should write in one block, in datax every 32mb data write a block， should we do as the same~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #4725: [Bugfix][Connector-V2][maxcompute] sink commit with Block not exsits on server
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4725:
URL: https://github.com/apache/incubator-seatunnel/pull/4725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] stdnt-xiao commented on pull request #4725: [Bugfix][Connector-V2][maxcompute] sink commit with Block not exsits on server
Posted by "stdnt-xiao (via GitHub)" <gi...@apache.org>.
stdnt-xiao commented on PR #4725:
URL: https://github.com/apache/incubator-seatunnel/pull/4725#issuecomment-1542222380
> i have anthor question . how many data should write in one block, in datax every 32mb data write a block， should we do as the same~
https://help.aliyun.com/document_detail/27838.html
<img width="863" alt="image" src="https://github.com/apache/incubator-seatunnel/assets/20313983/3f55a67d-d3c4-4823-9271-cf4aaf29e36f">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org