You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/11/20 12:29:00 UTC

[GitHub] [netbeans] KacerCZ commented on pull request #2537: [NETBEANS-5029] PHP - generated methods are public by default

KacerCZ commented on pull request #2537:
URL: https://github.com/apache/netbeans/pull/2537#issuecomment-731142094


   @junichi11 @tmysik Thanks for review.
   
   Regarding protected/public selection - I needed protected getter only in rare occasions and it was always easier to change generated code than change setting in dialog and then to remember change it back.
   
   If I understand this code correctly, then setting is saved to project:
   https://github.com/apache/netbeans/blob/f986c03ac36c77c077165a4e0e3d7e4b680bc562/php/php.editor/src/org/netbeans/modules/php/editor/codegen/CGSGenerator.java#L414-L445


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists