[GitHub] [drill] paul-rogers commented on issue #1889: DRILL-7436: Fix record count, vector structure issues in several operators

[GitBox <gi...@apache.org>]

paul-rogers commented on issue #1889: DRILL-7436: Fix record count, vector structure issues in several operators
URL: https://github.com/apache/drill/pull/1889#issuecomment-549196906
 
 
   Sorry for the large number of files changed: the batch count issues are complex and affect many bits of code.
   
   It may be hard to fully understand why certain things changed. This is why the `BathValidator` exists: it runs in every unit test to validate each batch, container and vector. You should assume that the changes all work toward getting each of the target operators to pass these checks.
   
   Note that many operators are not yet tested. This PR was supposed to just be the filter operator. But, it turned out that other operators were creating bad structures for which Filter got the blame. So, the scope had to expand to fix those upstream problems as well.
   
   Many of the changes, however, are code cleanup and should be quick to review.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services