You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/19 06:15:15 UTC

[GitHub] [pulsar] eolivelli opened a new pull request #10635: Remove ProducerSpec from Pulsar Functions GO, missing dependencies

eolivelli opened a new pull request #10635:
URL: https://github.com/apache/pulsar/pull/10635


   ### Motivation
   Integration tests on branch-2.7 do not work, because of a bunch of lines of code that were cherry-picked to branch-2.7.
   
   ### Modifications
   
   Remove the lines that do not compile because of missing dependencies (ProducerSpec).
   
   ### Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] sijie commented on pull request #10635: branch-2.7: Remove reference to ProducerSpec from Pulsar Functions GO

Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #10635:
URL: https://github.com/apache/pulsar/pull/10635#issuecomment-850506936


   @wolfstudy Can you review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli closed pull request #10635: branch-2.7: Remove reference to ProducerSpec from Pulsar Functions GO

Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #10635:
URL: https://github.com/apache/pulsar/pull/10635


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] eolivelli commented on pull request #10635: branch-2.7: Remove reference to ProducerSpec from Pulsar Functions GO

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10635:
URL: https://github.com/apache/pulsar/pull/10635#issuecomment-849461181


   @codelipenghui @merlimat PTAL


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org