You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2018/11/28 09:34:52 UTC
[GitHub] codecov-io commented on issue #500: SCB-1050 Metrics cache is not
clean
codecov-io commented on issue #500: SCB-1050 Metrics cache is not clean
URL: https://github.com/apache/servicecomb-service-center/pull/500#issuecomment-442381056
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=h1) Report
> Merging [#500](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/6a7379a35f939a2af837878d3aa61a8856c04ac4?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `72%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #500 +/- ##
=========================================
- Coverage 59.25% 59.2% -0.05%
=========================================
Files 166 166
Lines 13880 13878 -2
=========================================
- Hits 8224 8217 -7
- Misses 5072 5074 +2
- Partials 584 587 +3
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [server/metric/gatherer.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL21ldHJpYy9nYXRoZXJlci5nbw==) | `68.42% <100%> (+1.75%)` | :arrow_up: |
| [server/metric/metrics.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL21ldHJpYy9tZXRyaWNzLmdv) | `84% <66.66%> (-8.6%)` | :arrow_down: |
| [server/metric/calculator.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL21ldHJpYy9jYWxjdWxhdG9yLmdv) | `64% <75%> (ø)` | :arrow_up: |
| [server/plugin/pkg/registry/etcd/tracing.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvcmVnaXN0cnkvZXRjZC90cmFjaW5nLmdv) | `72.72% <0%> (-9.1%)` | :arrow_down: |
| [server/service/util/tag\_util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC90YWdfdXRpbC5nbw==) | `61.53% <0%> (-3.85%)` | :arrow_down: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `73.58% <0%> (-0.95%)` | :arrow_down: |
| [pkg/log/log\_zap.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dfemFwLmdv) | | |
| [pkg/log/log\_go19.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-cGtnL2xvZy9sb2dfZ28xOS5nbw==) | `100% <0%> (ø)` | |
| [server/govern/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL2dvdmVybi9zZXJ2aWNlLmdv) | `72.93% <0%> (+0.33%)` | :arrow_up: |
| [server/service/notification/websocket.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/500/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvbm90aWZpY2F0aW9uL3dlYnNvY2tldC5nbw==) | `84.51% <0%> (+0.64%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=footer). Last update [6a7379a...6e4d20a](https://codecov.io/gh/apache/servicecomb-service-center/pull/500?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services